Skip to content
Browse files

bpo-37758: Clean out vestigial script-bits from test_unicodedata. (GH…


This file started life as a script, before conversion to a
`unittest` test file.  Clear out some legacies of that conversion
that are a bit confusing about how it works.

Most notably, it's unlikely there's still a good reason to try
to recover from `unicodedata` failing to import -- as there was
when that logic was first added, when the module was very new.
So take that out entirely.  Keep `self.db` working, though, to
avoid a noisy diff.
  • Loading branch information...
gnprice authored and benjaminp committed Aug 13, 2019
1 parent 4e3dfcc commit def97c988be8340f33869b57942a30d10fc3a1f9
Showing with 5 additions and 17 deletions.
  1. +5 −17 Lib/test/
@@ -1,21 +1,17 @@
""" Test script for the unicodedata module.
""" Tests for the unicodedata module.
Written by Marc-Andre Lemburg (
(c) Copyright CNRI, All Rights Reserved. NO WARRANTY.

import hashlib
import sys
import unicodedata
import unittest
import hashlib
from import script_helper

encoding = 'utf-8'
errors = 'surrogatepass'

### Run tests

class UnicodeMethodsTest(unittest.TestCase):

@@ -61,20 +57,12 @@ def test_method_checksum(self):
(char + 'ABC').title(),

h.update(''.join(data).encode(encoding, errors))
h.update(''.join(data).encode('utf-8', 'surrogatepass'))
result = h.hexdigest()
self.assertEqual(result, self.expectedchecksum)

class UnicodeDatabaseTest(unittest.TestCase):

def setUp(self):
# In case unicodedata is not available, this will raise an ImportError,
# but the other test cases will still be run
import unicodedata
self.db = unicodedata

def tearDown(self):
del self.db
db = unicodedata

class UnicodeFunctionsTest(UnicodeDatabaseTest):

0 comments on commit def97c9

Please sign in to comment.
You can’t perform that action at this time.