Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-102388: Add windows_31j to aliases for cp932 codec #102389

Merged
merged 2 commits into from Feb 19, 2024

Conversation

moriyama
Copy link
Contributor

@moriyama moriyama commented Mar 3, 2023

The charset name "Windows-31J" is registered in the IANA Charset Registry[1] and is implemented in Python as the cp932 codec.

This commit adds windows_31j to the aliases of cp932.

[1] https://www.iana.org/assignments/charset-reg/windows-31J

@bedevere-bot
Copy link

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@cpython-cla-bot
Copy link

cpython-cla-bot bot commented Mar 3, 2023

All commit authors signed the Contributor License Agreement.
CLA signed

Copy link
Member

@malemburg malemburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Perhaps you could fix the many "py:class reference target not found: Codec" errors as part of this PR as well. I'm not really sure what's causing them - not a ResT expert.

Doc/library/codecs.rst Outdated Show resolved Hide resolved
moriyama and others added 2 commits February 19, 2024 12:54
The charset name "Windows-31J" is registered in the IANA Charset Registry[1]
and is implemented in Python as the cp932 codec.

This commit adds windows_31j to the aliases of cp932.

[1] https://www.iana.org/assignments/charset-reg/windows-31J

Signed-off-by: Masayuki Moriyama <masayuki.moriyama@miraclelinux.com>
@methane
Copy link
Member

methane commented Feb 19, 2024

Perhaps you could fix the many "py:class reference target not found: Codec" errors as part of this PR as well. I'm not really sure what's causing them - not a ResT expert.

There is no class Codec in the Doc/library/codecs.rst. It should be fixed in other pull request.

@methane methane merged commit 1476ac2 into python:main Feb 19, 2024
32 checks passed
@moriyama
Copy link
Contributor Author

Thank you for reviewing and merging.

woodruffw pushed a commit to woodruffw-forks/cpython that referenced this pull request Mar 4, 2024
…02389)

The charset name "Windows-31J" is registered in the IANA Charset Registry[1]
and is implemented in Python as the cp932 codec.

[1] https://www.iana.org/assignments/charset-reg/windows-31J

Signed-off-by: Masayuki Moriyama <masayuki.moriyama@miraclelinux.com>
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
…02389)

The charset name "Windows-31J" is registered in the IANA Charset Registry[1]
and is implemented in Python as the cp932 codec.

[1] https://www.iana.org/assignments/charset-reg/windows-31J

Signed-off-by: Masayuki Moriyama <masayuki.moriyama@miraclelinux.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants