Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_threading failed: test_reinit_tls_after_fork() failed with "env changed" on GHA Address Sanitizer: process 19857 is still running after 300.4 seconds #110031

Closed
vstinner opened this issue Sep 28, 2023 · 3 comments
Labels
tests Tests in the Lib/test dir

Comments

@vstinner
Copy link
Member

vstinner commented Sep 28, 2023

GHA Address Sanitizer:

test_reinit_tls_after_fork (test.test_threading.ThreadJoinOnShutdown.test_reinit_tls_after_fork) ... Warning -- Uncaught thread exception: AssertionError
Exception in thread Thread-35 (do_fork_and_wait):
Traceback (most recent call last):
  File "/home/runner/work/cpython/cpython/Lib/threading.py", line 1066, in _bootstrap_inner
    self.run()
  File "/home/runner/work/cpython/cpython/Lib/threading.py", line 1003, in run
    self._target(*self._args, **self._kwargs)
  File "/home/runner/work/cpython/cpython/Lib/test/test_threading.py", line 1185, in do_fork_and_wait
    support.wait_process(pid, exitcode=50)
  File "/home/runner/work/cpython/cpython/Lib/test/support/__init__.py", line 2202, in wait_process
    raise AssertionError(f"process {pid} is still running "
AssertionError: process 19857 is still running after 300.4 seconds
ok

build: https://github.com/python/cpython/actions/runs/6340021936/job/17220524327?pr=110026

Linked PRs

@vstinner vstinner added the tests Tests in the Lib/test dir label Sep 28, 2023
@vstinner
Copy link
Member Author

See also issue gh-110052 which looks similar.

@ericsnowcurrently
Copy link
Member

I'm not sure this is related. test_reinit_tls_after_fork() does not involve any daemon threads or subinterpreters. It actually reminds me of errors on gh-109846: https://github.com/python/cpython/actions/runs/6312835754/job/17139691845.

vstinner added a commit to vstinner/cpython that referenced this issue Sep 29, 2023
Skip test_threading tests using fork if Python is built with ASAN.
vstinner added a commit to vstinner/cpython that referenced this issue Sep 29, 2023
Skip test_threading tests using fork if Python is built with ASAN.
vstinner added a commit to vstinner/cpython that referenced this issue Sep 29, 2023
Skip test_threading tests using thread+fork if Python is built with
Address Sanitizer (ASAN).
@vstinner
Copy link
Member Author

@ericsnowcurrently:

I'm not sure this is related. test_reinit_tls_after_fork() does not involve any daemon threads or subinterpreters.

Oh, I was wrong: it's a ASAN build. I wrote PR #110100 to skip the test if Python is built with ASAN, as I already did for another test_threading test.

vstinner added a commit that referenced this issue Sep 29, 2023
Skip test_threading tests using thread+fork if Python is built with
Address Sanitizer (ASAN).
vstinner added a commit to vstinner/cpython that referenced this issue Sep 29, 2023
Skip test_threading tests using thread+fork if Python is built with
Address Sanitizer (ASAN).

(cherry picked from commit 86e76ab)
vstinner added a commit that referenced this issue Sep 29, 2023
…110104)

gh-110031: Skip test_threading fork tests if ASAN (#110100)

Skip test_threading tests using thread+fork if Python is built with
Address Sanitizer (ASAN).

(cherry picked from commit 86e76ab)
vstinner added a commit to vstinner/cpython that referenced this issue Oct 2, 2023
Skip test_threading tests using thread+fork if Python is built with
Address Sanitizer (ASAN).

(cherry picked from commit 86e76ab)
vstinner added a commit that referenced this issue Oct 2, 2023
…110103)

gh-110031: Skip test_threading fork tests if ASAN (#110100)

Skip test_threading tests using thread+fork if Python is built with
Address Sanitizer (ASAN).

(cherry picked from commit 86e76ab)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Tests in the Lib/test dir
Projects
None yet
Development

No branches or pull requests

2 participants