Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for pickling and copying PyStructSequence objects #110267

Closed
serhiy-storchaka opened this issue Oct 3, 2023 · 0 comments · Fixed by #110272
Closed

Add tests for pickling and copying PyStructSequence objects #110267

serhiy-storchaka opened this issue Oct 3, 2023 · 0 comments · Fixed by #110272
Labels
3.11 only security fixes 3.12 bugs and security fixes 3.13 new features, bugs and security fixes easy tests Tests in the Lib/test dir

Comments

@serhiy-storchaka
Copy link
Member

serhiy-storchaka commented Oct 3, 2023 •
edited by bedevere-app bot

PyStructSequence supports pickling and copying, but there are no tests for this. There is only one trivial test which tests that __reduce__() does not raise exception or crash.

Needed explicit tests for copy.copy(), copy.deepcopy() (it is the same, but still), pickle.dumps()/pickle.loads().

cc @XuehaiPan

Linked PRs
@serhiy-storchaka serhiy-storchaka added tests Tests in the Lib/test dir 3.11 only security fixes easy 3.12 bugs and security fixes 3.13 new features, bugs and security fixes labels Oct 3, 2023
@serhiy-storchaka serhiy-storchaka mentioned this issue Oct 3, 2023
Merged
@XuehaiPan XuehaiPan mentioned this issue Oct 3, 2023
Merged
serhiy-storchaka pushed a commit that referenced this issue Oct 3, 2023
@XuehaiPan
gh-110267: Add tests for pickling and copying PyStructSequence objects (
2d4865d 
GH-110272)
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Oct 3, 2023
@XuehaiPan @miss-islington
pythongh-110267: Add tests for pickling and copying PyStructSequence …
d0893dc 
…objects (pythonGH-110272)

(cherry picked from commit 2d4865d)

Co-authored-by: Xuehai Pan <XuehaiPan@pku.edu.cn>
@bedevere-app bedevere-app bot mentioned this issue Oct 3, 2023
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Oct 3, 2023
@XuehaiPan @miss-islington
pythongh-110267: Add tests for pickling and copying PyStructSequence …
dbab1b0 
…objects (pythonGH-110272)

(cherry picked from commit 2d4865d)

Co-authored-by: Xuehai Pan <XuehaiPan@pku.edu.cn>
@bedevere-app bedevere-app bot mentioned this issue Oct 3, 2023
Merged
serhiy-storchaka pushed a commit that referenced this issue Oct 4, 2023
@miss-islington @XuehaiPan
[3.12] gh-110267: Add tests for pickling and copying PyStructSequence…
35feda5 
… objects (GH-110272) (GH-110285)

(cherry picked from commit 2d4865d)

Co-authored-by: Xuehai Pan <XuehaiPan@pku.edu.cn>
serhiy-storchaka pushed a commit that referenced this issue Oct 4, 2023
@miss-islington @XuehaiPan
[3.11] gh-110267: Add tests for pickling and copying PyStructSequence…
5039db7 
… objects (GH-110272) (GH-110284)

(cherry picked from commit 2d4865d)

Co-authored-by: Xuehai Pan <XuehaiPan@pku.edu.cn>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.11 only security fixes 3.12 bugs and security fixes 3.13 new features, bugs and security fixes easy tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gh-110267: Add tests for pickling and copying PyStructSequence objects XuehaiPan/cpython
1 participant
@serhiy-storchaka