Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not clear arbitrary errors on import #112660

Closed
serhiy-storchaka opened this issue Dec 3, 2023 · 0 comments
Closed

Do not clear arbitrary errors on import #112660

serhiy-storchaka opened this issue Dec 3, 2023 · 0 comments
Labels
topic-importlib

Comments

@serhiy-storchaka
Copy link
Member

serhiy-storchaka commented Dec 3, 2023 •
edited by bedevere-app bot

Currently the import and module code can clear arbitrary errors when format error message for ImportError or AttributeError and override them with ImportError or AttributeError. Usually it is not an issue, because these errors (accessing missed attribute or dict key) should be ignored, but in theory it can be arbitrary error, like KeyboardInterrupt, MemoryError or Recursion error which should not be ignored.

Linked PRs
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this issue Dec 3, 2023
@serhiy-storchaka
pythongh-112660: Do not clear arbitrary errors on import
8097bc4 
Previously arbitrary errors could be cleared during formatting error
messages for ImportError or AttributeError for modules. Now all
unexpected errors are reported.
@bedevere-app bedevere-app bot mentioned this issue Dec 3, 2023
Merged
@serhiy-storchaka serhiy-storchaka mentioned this issue Dec 3, 2023
Merged
serhiy-storchaka added a commit that referenced this issue Dec 7, 2023
@serhiy-storchaka
gh-112660: Do not clear arbitrary errors on import (GH-112661)
8660fb7 
Previously arbitrary errors could be cleared during formatting error
messages for ImportError or AttributeError for modules. Now all
unexpected errors are reported.
@hauntsaninja hauntsaninja mentioned this issue Jan 28, 2024
Merged
aisk pushed a commit to aisk/cpython that referenced this issue Feb 11, 2024
@serhiy-storchaka @aisk
pythongh-112660: Do not clear arbitrary errors on import (pythonGH-11…
f467718 
…2661)

Previously arbitrary errors could be cleared during formatting error
messages for ImportError or AttributeError for modules. Now all
unexpected errors are reported.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic-importlib
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@serhiy-storchaka