Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed up posixpath.realpath() #114847

Closed
barneygale opened this issue Feb 1, 2024 · 2 comments
Closed

Speed up posixpath.realpath() #114847

barneygale opened this issue Feb 1, 2024 · 2 comments
Labels
performance Performance or resource usage stdlib Python modules in the Lib dir

Comments

@barneygale
Copy link
Contributor

barneygale commented Feb 1, 2024 •
edited by bedevere-app bot
Loading

Some optimizations to posixpath.realpath() are possible - see attached PR.

Linked PRs
@barneygale barneygale added performance Performance or resource usage stdlib Python modules in the Lib dir labels Feb 1, 2024
barneygale added a commit to barneygale/cpython that referenced this issue Feb 1, 2024
@barneygale
pythonGH-114847: Speed up posixpath.realpath()
dfe0320 
Apply the following optimizations to `posixpath.realpath()`:

- Remove use of recursion
- Directly construct child paths rather than using `join()`
- Use `os.getcwd[b]()` rather than `abspath()`
- Use `startswith(sep)` rather than `isabs()`
barneygale added a commit to barneygale/cpython that referenced this issue Feb 1, 2024
@barneygale
pythonGH-114847: Speed up posixpath.realpath()
0a4f60a 
Apply the following optimizations to `posixpath.realpath()`:

- Remove use of recursion
- Directly construct child paths rather than using `join()`
- Use `os.getcwd[b]()` rather than `abspath()`
- Use `startswith(sep)` rather than `isabs()`
@bedevere-app bedevere-app bot mentioned this issue Feb 1, 2024
Merged
barneygale added a commit to barneygale/cpython that referenced this issue Mar 31, 2024
@barneygale
Merge branch 'main' into pythongh-114847
eb079b4
barneygale added a commit to barneygale/cpython that referenced this issue Apr 1, 2024
@barneygale
Merge branch 'main' into pythongh-114847
b03e474
barneygale added a commit to barneygale/cpython that referenced this issue Apr 2, 2024
@barneygale
pythonGH-114847: Raise FileNotFoundError when getcwd() returns '(unre…
394984d 
…achable)'

On Linux >= 2.6.36 with glibc < 2.27, `getcwd()` can return a relative
pathname starting with '(unreachable)'. We detect this and fail with
ENOENT, matching new glibc behaviour.
@bedevere-app bedevere-app bot mentioned this issue Apr 2, 2024
Merged
barneygale added a commit to barneygale/cpython that referenced this issue Apr 2, 2024
@barneygale
Merge branch 'main' into pythongh-114847
8b3b808
barneygale added a commit that referenced this issue Apr 3, 2024
@barneygale @encukou
GH-114847: Raise FileNotFoundError when getcwd() returns '(unreachabl…
345194d 
…e)' (#117481)

On Linux >= 2.6.36 with glibc < 2.27, `getcwd()` can return a relative
pathname starting with '(unreachable)'. We detect this and fail with
ENOENT, matching new glibc behaviour.

Co-authored-by: Petr Viktorin <encukou@gmail.com>
barneygale added a commit to barneygale/cpython that referenced this issue Apr 3, 2024
@barneygale
Merge branch 'main' into pythongh-114847
01127e3
barneygale added a commit to barneygale/cpython that referenced this issue Apr 4, 2024
@barneygale
Merge branch 'main' into pythongh-114847
211167e
@encukou

This comment was marked as off-topic.

Sign in to view
barneygale added a commit to barneygale/cpython that referenced this issue Apr 4, 2024
@barneygale
Merge branch 'main' into pythongh-114847
ecbb27c
barneygale added a commit that referenced this issue Apr 5, 2024
@barneygale @encukou
GH-114847: Speed up posixpath.realpath() (#114848)
abfa16b 
Apply the following optimizations to `posixpath.realpath()`:

- Remove use of recursion
- Construct child paths directly rather than using `join()`
- Use `os.getcwd[b]()` rather than `abspath()`
- Use `startswith(sep)` rather than `isabs()`
- Use slicing rather than `split()`

Co-authored-by: Petr Viktorin <encukou@gmail.com>
@encukou
Copy link
Member

encukou commented Apr 8, 2024

Thank you!

@encukou encukou closed this as completed Apr 8, 2024
diegorusso pushed a commit to diegorusso/cpython that referenced this issue Apr 17, 2024
@barneygale @encukou @diegorusso
pythonGH-114847: Raise FileNotFoundError when getcwd() returns '(unre…
d294a89 
…achable)' (python#117481)

On Linux >= 2.6.36 with glibc < 2.27, `getcwd()` can return a relative
pathname starting with '(unreachable)'. We detect this and fail with
ENOENT, matching new glibc behaviour.

Co-authored-by: Petr Viktorin <encukou@gmail.com>
diegorusso pushed a commit to diegorusso/cpython that referenced this issue Apr 17, 2024
@barneygale @encukou @diegorusso
pythonGH-114847: Speed up posixpath.realpath() (python#114848)
c20c138 
Apply the following optimizations to `posixpath.realpath()`:

- Remove use of recursion
- Construct child paths directly rather than using `join()`
- Use `os.getcwd[b]()` rather than `abspath()`
- Use `startswith(sep)` rather than `isabs()`
- Use slicing rather than `split()`

Co-authored-by: Petr Viktorin <encukou@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
performance Performance or resource usage stdlib Python modules in the Lib dir
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@encukou @barneygale