Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid Assert in PyState_FindModule() #119560

Closed
ericsnowcurrently opened this issue May 25, 2024 · 1 comment
Closed

Invalid Assert in PyState_FindModule() #119560

ericsnowcurrently opened this issue May 25, 2024 · 1 comment
Assignees
@ericsnowcurrently
Labels
3.13 bugs and security fixes 3.14 new features, bugs and security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) type-crash A hard crash of the interpreter, possibly with a core dump

Comments

@ericsnowcurrently
Copy link
Member

ericsnowcurrently commented May 25, 2024 •
edited by bedevere-app bot
Loading

Crash report

Bug description:

gh-118532 added an assert that is erroneously triggers if PyState_FindModule() is called before the provided module def has been initialized. The assert should be removed. (Python/import.c, line 460)

See ultrajson/ultrajson#629.

CPython versions tested on:

3.13, CPython main branch

Operating systems tested on:

No response

Linked PRs
@ericsnowcurrently ericsnowcurrently added interpreter-core (Objects, Python, Grammar, and Parser dirs) type-crash A hard crash of the interpreter, possibly with a core dump 3.13 bugs and security fixes 3.14 new features, bugs and security fixes labels May 25, 2024
@ericsnowcurrently ericsnowcurrently self-assigned this May 25, 2024
@bedevere-app bedevere-app bot mentioned this issue May 25, 2024
Merged
ericsnowcurrently added a commit that referenced this issue May 25, 2024
@ericsnowcurrently
gh-119560: Drop an Invalid Assert in PyState_FindModule() (gh-119561)
0c5ebe1 
The assertion was added in gh-118532 but was based on the invalid assumption that PyState_FindModule() would only be called with an already-initialized module def.  I've added a test to make sure we don't make that assumption again.
@mgorny
Copy link
Contributor

mgorny commented May 26, 2024

Thanks. I can confirm that after applying this on top of 3.13.0b1, ujson passes all tests.

miss-islington pushed a commit to miss-islington/cpython that referenced this issue May 27, 2024
@ericsnowcurrently @miss-islington
pythongh-119560: Drop an Invalid Assert in PyState_FindModule() (pyth…
f7e1d05 
…ongh-119561)

The assertion was added in pythongh-118532 but was based on the invalid assumption that PyState_FindModule() would only be called with an already-initialized module def.  I've added a test to make sure we don't make that assumption again.
(cherry picked from commit 0c5ebe1)

Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
@bedevere-app bedevere-app bot mentioned this issue May 27, 2024
Merged
ericsnowcurrently added a commit that referenced this issue May 27, 2024
@miss-islington @ericsnowcurrently
[3.13] gh-119560: Drop an Invalid Assert in PyState_FindModule() (gh-…
bd9983c 
…119561) (gh-119632)

The assertion was added in gh-118532 but was based on the invalid assumption that PyState_FindModule() would only be called with an already-initialized module def.  I've added a test to make sure we don't make that assumption again.

(cherry picked from commit 0c5ebe1)

Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
@JelleZijlstra JelleZijlstra mentioned this issue May 28, 2024
Closed
estyxx pushed a commit to estyxx/cpython that referenced this issue Jul 17, 2024
@ericsnowcurrently @estyxx
pythongh-119560: Drop an Invalid Assert in PyState_FindModule() (pyth…
c3cff43 
…ongh-119561)

The assertion was added in pythongh-118532 but was based on the invalid assumption that PyState_FindModule() would only be called with an already-initialized module def.  I've added a test to make sure we don't make that assumption again.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ericsnowcurrently ericsnowcurrently

Labels
3.13 bugs and security fixes 3.14 new features, bugs and security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) type-crash A hard crash of the interpreter, possibly with a core dump
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mgorny @ericsnowcurrently