GhostBSD 20.10.1 python3 build failed: ./Modules/posixmodule.c:8817:21: error: 'I_PUSH' undeclared

[Suryavarman]

Bug report

Bug description:

I want to compile python on my GhostBSD 20.10.1 OS based on freeBSD 14.1 STABLE
The bug is the same for python 3.11, 3.12, 3.13.
I have not tried with earlier versions.

Here is the bug:
ptmx is detected, but stropts.h does not exist.

In the ./Modules/posixmodule.c file, on lines 8814, 8815 and 8816, there is no test to see if HAVE_STROPTS_H is defined, even though the variable I_PUSH defined in stropts.h is used.

I've looked hard but in the current version of GhostBSD stropts.h is no longer included.
While browsing the internet, I read here and there that stropts.h was no longer part of posix.
EDIT: Removed in POSIX.1-2024.

To solve the problem I could install openpty, but this library doesn't seem to be available any more either.

# checking for stropts.h... no
# checking for pty.h... no
# checking for _getpty... no
# checking for openpty... no
# checking for openpty in -lutil... no
# checking for openpty in -lbsd... no
# checking for library containing login_tty... no
# checking for forkpty... no
# checking for forkpty in -lutil... no
# checking for forkpty in -lbsd... no
# checking for /dev/ptmx... yes 

CPython versions tested on:

3.13

Operating systems tested on:

No response

[Suryavarman]

https://www.gnu.org/software/gnulib/manual/html_node/stropts_002eh.html

This header file is missing on some platforms: macOS 14, FreeBSD 14.0, NetBSD 10.0, OpenBSD 7.5, Minix 3.1.8, Cygwin, mingw, MSVC 14, Android 9.

[picnixz]

I guess we could make it work with an additional include guard. WDYT @vstinner?

[Suryavarman]

This is weird.
When running ./configure
libutil is tested but it considers that openpty is not present.

I checked if libutil was present. It is present by default.
/lib/libutil.so.9

The openpty function is present.

nm -D libutil.so.9 
000000000000f970 T openpty

cf: https://man.freebsd.org/cgi/man.cgi?query=openpty

I don't understand why ./configure can't find openpty.
Just in case, here is the command:
./configure --prefix="/home/.../ma/dependencies/venv" --enable-shared LDFLAGS=-Wl,-rpath="/home/.../ma/dependencies/venv/lib" --enable-optimization

[Suryavarman]

configure:21901: checking for openpty in -lutil
configure:21924: gcc14 -pthread -o conftest   -Wl,-rpath=/home/.../ma/dependencies/venv/lib conftest.c -lutil  -lintl -ldl  >&5
/usr/local/bin/ld: cannot find -lutil: No such file or directory

ls /lib | grep libutil

libutil.so.9

ldconfig -r > test.log

-lutil.9 => /lib/libutil.so.9

> gcc14 -o test -lutil -lc++ test.o
/usr/local/bin/ld: cannot find -lutil: No such file or directory
collect2: error: ld returned 1 exit status

> gcc14 -o test -lc++ test.o
/usr/local/bin/ld: test.o: in function `main':
openpyt_test.cpp:(.text+0x5): undefined reference to `openpty'

libutil.so.9 does exist, but the ld cannot find it, even when specifying the full path.

I don't get it.

This is becoming more of a freeBSD problem.

[Suryavarman]

A stupid solution :( :

sudo ln -s /lib/libutil.so.9 /lib/libutil.so

And it's works.

# bash output
checking for openpty... no
checking for openpty in -lutil... yes

# config.log
configure:21901: checking for openpty in -lutil
configure:21924: gcc14 -pthread -o conftest   -Wl,-rpath=/home/.../ma/dependencies/venv/lib conftest.c -lutil  -lintl -ldl  >&5
configure:21924: $? = 0
configure:21934: result: yes

But it's not enough 🤯 :

--- Modules/posixmodule.o ---
    ./Modules/posixmodule.c: In function 'os_openpty_impl':
    ./Modules/posixmodule.c:8761:9: error: implicit declaration of function 'openpty'; did you mean 'openat'? [-Wimplicit-function-declaration]
     8761 |     if (openpty(&master_fd, &slave_fd, NULL, NULL, NULL) != 0)
          |         ^~~~~~~
          |         openat

    --- Modules/posixmodule.o ---
    ./Modules/posixmodule.c: In function 'os_login_tty_impl':
    ./Modules/posixmodule.c:8862:9: error: implicit declaration of function 'login_tty' [-Wimplicit-function-declaration]
     8862 |     if (login_tty(fd) == -1) {
          |         ^~~~~~~~~
    ./Modules/posixmodule.c: In function 'os_forkpty_impl':
    ./Modules/posixmodule.c:8922:11: error: implicit declaration of function 'forkpty'; did you mean 'fork'? [-Wimplicit-function-declaration]
     8922 |     pid = forkpty(&master_fd, NULL, NULL, NULL);
          |           ^~~~~~~
          |           fork

[Suryavarman]

Maybe because of this:

checking for libutil.h... no
checking for util.h... no
checking for utmp.h... no
checking for pty.h... no

There no header to include the openpty declaration.

posxmodule.c : line 8718

#if defined(HAVE_OPENPTY) || defined(HAVE_FORKPTY) || defined(HAVE_LOGIN_TTY) || defined(HAVE_DEV_PTMX)
#ifdef HAVE_PTY_H
#include <pty.h>
#ifdef HAVE_UTMP_H
#include <utmp.h>
#endif /* HAVE_UTMP_H */
#elif defined(HAVE_LIBUTIL_H)
#include <libutil.h>
#elif defined(HAVE_UTIL_H)
#include <util.h>
#endif /* HAVE_PTY_H */
#ifdef HAVE_STROPTS_H
#include <stropts.h>
#endif
#endif /* defined(HAVE_OPENPTY) || defined(HAVE_FORKPTY) || defined(HAVE_LOGIN_TTY) || defined(HAVE_DEV_PTMX) */

if I look at the freebsd documentation, openpty is declared in
#include <libutil.h>

https://man.freebsd.org/cgi/man.cgi?query=openpty

[vstinner]

From what I understood, Python cannot be built on GhostBSD because of missing I_PUSH symbol in posixmodule.c. I didn't understand which header is supposed to provide it. Does this symbol exist on GhostBSD?

[Suryavarman]

The solution:
sudo pkg install -g 'GhostBSD*-dev'

The explication:
https://forums.ghostbsd.org/d/194-where-is-libutilh