Exception thrown by shlex.quote changed in 3.14 and is not documented

[cybit]

Bug report

Bug description:

It seems to me that #132036 not only made the import time faster but did also change the exception thrown if the arguments in shlex.quote are not of type str.

It used to be "TypeError", now it is "AttributeError" .

I am not able to find this change in the release notes or the PR.

Test code:

import shlex

shlex.quote(123)

Test run on the shell:

➜ for i in 10 11 12 13 14 ; do echo "3.$i" ; uv run --python 3.$i test.py 2>&1 | tail -n 1 ; done
3.10
TypeError: expected string or bytes-like object
3.11
TypeError: expected string or bytes-like object, got 'int'
3.12
TypeError: expected string or bytes-like object, got 'int'
3.13
TypeError: expected string or bytes-like object, got 'int'
3.14
AttributeError: 'int' object has no attribute 'isascii'

CPython versions tested on:

3.10, 3.11, 3.12, 3.13, 3.14

Operating systems tested on:

macOS

Linked PRs

• gh-138804: Check type in shlex.quote #138809
• [3.14] gh-138804: Check type in shlex.quote (GH-138809) #138846

[StanFromIreland]

For reference, on 3.13:

>>> import shlex
... 
... shlex.quote(123)
... 
Traceback (most recent call last):
  File "<python-input-0>", line 3, in <module>
    shlex.quote(123)
    ~~~~~~~~~~~^^^^^
  File "/usr/lib64/python3.13/shlex.py", line 327, in quote
    if _find_unsafe(s) is None:
       ~~~~~~~~~~~~^^^
TypeError: expected string or bytes-like object, got 'int'

cc @AA-Turner

[picnixz]

A check of the form if isinstance(s, str | bytes): or if isinstance(s, (str, bytes)): (don't know which one is the preferred way in this module). shouldn't be too costly here so let's add it. Before, it was implicitly done in _find_unsafe as it relied on re.Pattern.search.

[wiomoc]

A check of the form if isinstance(s, str | bytes): or if isinstance(s, (str, bytes)): (don't know which one is the preferred way in this module). shouldn't be too costly here so let's add it. Before, it was implicitly done in _find_unsafe as it relied on re.Pattern.search.

As encode() is called on the argument, passing a bytes object should raise a TypeError too.

[cybit]

As encode() is called on the argument, passing a bytes object should raise a TypeError too.

Might that be the reason for #69753 ?