3.14.0rc3 HACL implicit declaration of function 'aligned_alloc'

[chargr]

Bug report

Bug description:

centos6/glibc 2.12 does not have aligned_alloc

67daa0ccf3ef: In file included from ./Modules/_hacl/include/krml/FStar_UInt_8_16_32_64.h:15,
67daa0ccf3ef: from ./Modules/_hacl/include/krml/FStar_UInt128_Verified.h:10,
67daa0ccf3ef: from ./Modules/_hacl/include/krml/internal/types.h:102,
67daa0ccf3ef: from ./Modules/_hacl/internal/Hacl_Hash_Blake2s_Simd128.h:34,
67daa0ccf3ef: from ./Modules/_hacl/Hacl_Hash_Blake2s_Simd128.c:26:
67daa0ccf3ef: ./Modules/_hacl/Hacl_Hash_Blake2s_Simd128.c: In function '_Py_LibHacl_Hacl_Hash_Blake2s_Simd128_malloc_internal_state_with_key':
67daa0ccf3ef: ./Modules/_hacl/include/krml/internal/target.h:153:39: error: implicit declaration of function 'aligned_alloc' [-Werror=implicit-function-declaration]
67daa0ccf3ef: 153 | #    define KRML_ALIGNED_MALLOC(X, Y) aligned_alloc(X, Y)
67daa0ccf3ef: |                                       ^~~~~~~~~~~~~
67daa0ccf3ef: ./Modules/_hacl/Hacl_Hash_Blake2s_Simd128.c:526:40: note: in expansion of macro 'KRML_ALIGNED_MALLOC'
67daa0ccf3ef: 526 |     (Lib_IntVector_Intrinsics_vec128 *)KRML_ALIGNED_MALLOC(16,
67daa0ccf3ef: |                                        ^~~~~~~~~~~~~~~~~~~
67daa0ccf3ef: ./Modules/_hacl/Hacl_Hash_Blake2s_Simd128.c:34:1: note: include '<stdlib.h>' or provide a declaration of 'aligned_alloc'
67daa0ccf3ef: 33 | #include "lib_memzero0.h"
67daa0ccf3ef: +++ |+#include <stdlib.h>
67daa0ccf3ef: 34 |
67daa0ccf3ef: ./Modules/_hacl/include/krml/internal/target.h:153:39: warning: incompatible implicit declaration of built-in function 'aligned_alloc' [-Wbuiltin-declaration-mismatch]
67daa0ccf3ef: 153 | #    define KRML_ALIGNED_MALLOC(X, Y) aligned_alloc(X, Y)
67daa0ccf3ef: |                                       ^~~~~~~~~~~~~
67daa0ccf3ef: ./Modules/_hacl/Hacl_Hash_Blake2s_Simd128.c:526:40: note: in expansion of macro 'KRML_ALIGNED_MALLOC'
67daa0ccf3ef: 526 |     (Lib_IntVector_Intrinsics_vec128 *)KRML_ALIGNED_MALLOC(16,
67daa0ccf3ef: |                                        ^~~~~~~~~~~~~~~~~~~
67daa0ccf3ef: ./Modules/_hacl/include/krml/internal/target.h:153:39: note: include '<stdlib.h>' or provide a declaration of 'aligned_alloc'
67daa0ccf3ef: 153 | #    define KRML_ALIGNED_MALLOC(X, Y) aligned_alloc(X, Y)
67daa0ccf3ef: |                                       ^~~~~~~~~~~~~
67daa0ccf3ef: ./Modules/_hacl/Hacl_Hash_Blake2s_Simd128.c:526:40: note: in expansion of macro 'KRML_ALIGNED_MALLOC'
67daa0ccf3ef: 526 |     (Lib_IntVector_Intrinsics_vec128 *)KRML_ALIGNED_MALLOC(16,
67daa0ccf3ef: |                                        ^~~~~~~~~~~~~~~~~~~
67daa0ccf3ef: ./Modules/_hacl/Hacl_Hash_Blake2s_Simd128.c: In function 'malloc_raw':
67daa0ccf3ef: ./Modules/_hacl/include/krml/internal/target.h:153:39: warning: incompatible implicit declaration of built-in function 'aligned_alloc' [-Wbuiltin-declaration-mismatch]
67daa0ccf3ef: 153 | #    define KRML_ALIGNED_MALLOC(X, Y) aligned_alloc(X, Y)
67daa0ccf3ef: |                                       ^~~~~~~~~~~~~
67daa0ccf3ef: ./Modules/_hacl/Hacl_Hash_Blake2s_Simd128.c:587:40: note: in expansion of macro 'KRML_ALIGNED_MALLOC'
67daa0ccf3ef: 587 |     (Lib_IntVector_Intrinsics_vec128 *)KRML_ALIGNED_MALLOC(16,
67daa0ccf3ef: |                                        ^~~~~~~~~~~~~~~~~~~
67daa0ccf3ef: ./Modules/_hacl/include/krml/internal/target.h:153:39: note: include '<stdlib.h>' or provide a declaration of 'aligned_alloc'
67daa0ccf3ef: 153 | #    define KRML_ALIGNED_MALLOC(X, Y) aligned_alloc(X, Y)
67daa0ccf3ef: |                                       ^~~~~~~~~~~~~
67daa0ccf3ef: ./Modules/_hacl/Hacl_Hash_Blake2s_Simd128.c:587:40: note: in expansion of macro 'KRML_ALIGNED_MALLOC'
67daa0ccf3ef: 587 |     (Lib_IntVector_Intrinsics_vec128 *)KRML_ALIGNED_MALLOC(16,
67daa0ccf3ef: |                                        ^~~~~~~~~~~~~~~~~~~
67daa0ccf3ef: ./Modules/_hacl/Hacl_Hash_Blake2s_Simd128.c: In function '_Py_LibHacl_Hacl_Hash_Blake2s_Simd128_copy':
67daa0ccf3ef: ./Modules/_hacl/include/krml/internal/target.h:153:39: warning: incompatible implicit declaration of built-in function 'aligned_alloc' [-Wbuiltin-declaration-mismatch]
67daa0ccf3ef: 153 | #    define KRML_ALIGNED_MALLOC(X, Y) aligned_alloc(X, Y)
67daa0ccf3ef: |                                       ^~~~~~~~~~~~~
67daa0ccf3ef: ./Modules/_hacl/Hacl_Hash_Blake2s_Simd128.c:1337:40: note: in expansion of macro 'KRML_ALIGNED_MALLOC'
67daa0ccf3ef: 1337 |     (Lib_IntVector_Intrinsics_vec128 *)KRML_ALIGNED_MALLOC(16,
67daa0ccf3ef: |                                        ^~~~~~~~~~~~~~~~~~~
67daa0ccf3ef: ./Modules/_hacl/include/krml/internal/target.h:153:39: note: include '<stdlib.h>' or provide a declaration of 'aligned_alloc'
67daa0ccf3ef: 153 | #    define KRML_ALIGNED_MALLOC(X, Y) aligned_alloc(X, Y)
67daa0ccf3ef: |                                       ^~~~~~~~~~~~~
67daa0ccf3ef: ./Modules/_hacl/Hacl_Hash_Blake2s_Simd128.c:1337:40: note: in expansion of macro 'KRML_ALIGNED_MALLOC'
67daa0ccf3ef: 1337 |     (Lib_IntVector_Intrinsics_vec128 *)KRML_ALIGNED_MALLOC(16,
67daa0ccf3ef: |                                        ^~~~~~~~~~~~~~~~~~~

CPython versions tested on:

3.14

Operating systems tested on:

Linux

[picnixz]

(this is a bundled source issue, so we can't do much)

cc @protz

[picnixz]

It appears that aligned_alloc was added in glibc@2.16, but I don't know if we are expected to support that old glibc actually.

[chargr]

not a hard requirement for me, i can move 3.14 to minimum of c7/glibc2.17. just curious if it could/should work.

[picnixz]

This makes me wonder whether we should have some configure check / compile-time #error here instead of a wild "implicit function" issue.

[protz]

Sorry -- just catching up on this, was on vacation last week and starting a new job this week.

The upstream header assumes aligned_alloc because aligned_alloc is in C11 (https://en.cppreference.com/w/c/memory/aligned_alloc) and several folks have mentioned here that Python assumes C11.

I'm not sure if you want to support CentOS 6 (released in 2011), given that it does not have support for C11.

If you want Python to support CentOS 6, then I have two options in mind:

• bad option: a patch to https://github.com/FStarLang/karamel/blob/master/include/krml/internal/target.h#L156 to expose a fallback for pre-C11 toolchains, maybe with a GCC expression-statement that mallocs then aligns (not super portable)
• better option: a check at configure-time that detects the absence of aligned_malloc, then proceeds to link an additional .o that contains a hand-written python_aligned_malloc, followed by -DKRML_ALIGNED_ALLOC=python_aligned_malloc on the command-line

Regardless of whether you want to bother supporting this at all, a check at configure-time seems like a good idea (along with a usable error along the lines of "we expect C11 including the functions from the standard library, not just the language features")

Hope this helps..

[picnixz]

The upstream header assumes aligned_alloc because aligned_alloc is in C11

Following this, I will close this issue as wont fix. Thank you for the report but this won't be fixed as this not meet our minimal requirements.

better option: a check at configure-time that detects the absence of aligned_malloc, then proceeds to link an additional .o that contains a hand-written python_aligned_malloc, followed by -DKRML_ALIGNED_ALLOC=python_aligned_malloc on the command-line

For now, this would be too cumbersome. We already have a complex build step and I don't want to over-complicate it.

Regardless of whether you want to bother supporting this at all, a check at configure-time seems like a good idea (along with a usable error along the lines of "we expect C11 including the functions from the standard library, not just the language features")

Now that I think more about it, the problem would be that we need to probably check all C11 functions and that would be a bit annoying in general.