unittest string format error

[dalke]

BPO	418489

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2001-05-10.01:31:35.000>
created_at = <Date 2001-04-24.06:58:21.000>
labels = ['library']
title = 'unittest string format error'
updated_at = <Date 2001-05-10.01:31:35.000>
user = 'https://bugs.python.org/dalke'

bugs.python.org fields:

activity = <Date 2001-05-10.01:31:35.000>
actor = 'purcell'
assignee = 'purcell'
closed = True
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2001-04-24.06:58:21.000>
creator = 'dalke'
dependencies = []
files = []
hgrepos = []
issue_num = 418489
keywords = ['patch']
message_count = 2.0
messages = ['36447', '36448']
nosy_count = 2.0
nosy_names = ['dalke', 'purcell']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue418489'
versions = []

[dalke]

unittest.loadTestsFromName has a string format error
of the form - it needs some parens. Currently is:

raise ValueError, \
"calling %s returned %s, not a test" % obj,test

should be

raise ValueError, \
"calling %s returned %s, not a test" % (obj,test)

Let's see if this really will let me upload a patch.

Index: unittest.py
=======================================================
============
RCS
file: /cvsroot/python/python/dist/src/Lib/unittest.py,v
retrieving revision 1.7
diff -c -r1.7 unittest.py
*** unittest.py 2001/04/15 09:18:32 1.7
--- unittest.py 2001/04/24 06:57:32

---

*** 443,449 ****
if not isinstance(test, TestCase) and \
not isinstance(test, TestSuite):
raise ValueError, \
! "calling %s returned %s, not a
test" % obj,test
return test
else:
raise ValueError, "don't know how to
make test from: %s" % obj
--- 443,449 ----
if not isinstance(test, TestCase) and \
not isinstance(test, TestSuite):
raise ValueError, \
! "calling %s returned %s, not a
test" % (obj, test)
return test
else:
raise ValueError, "don't know how to
make test from: %s" % obj

[purcell]

Logged In: YES
user_id=21477

Thanks Andrew.