Reference counting bugs

[arigo]

BPO	488477
Nosy	@gvanrossum, @tim-one, @arigo

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/gvanrossum'
closed_at = <Date 2001-12-03.19:45:18.000>
created_at = <Date 2001-12-03.17:09:29.000>
labels = ['interpreter-core']
title = 'Reference counting bugs'
updated_at = <Date 2001-12-03.19:45:18.000>
user = 'https://github.com/arigo'

bugs.python.org fields:

activity = <Date 2001-12-03.19:45:18.000>
actor = 'gvanrossum'
assignee = 'gvanrossum'
closed = True
closed_date = None
closer = None
components = ['Interpreter Core']
creation = <Date 2001-12-03.17:09:29.000>
creator = 'arigo'
dependencies = []
files = []
hgrepos = []
issue_num = 488477
keywords = []
message_count = 4.0
messages = ['7955', '7956', '7957', '7958']
nosy_count = 3.0
nosy_names = ['gvanrossum', 'tim.peters', 'arigo']
pr_nums = []
priority = 'high'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue488477'
versions = []

[arigo]

Various refcounting bugs:

1. Objects/abstract.c: PyObject_Call():
   missing Py_DECREF() on the object returned by
   PyObject_Repr(func). Moreover this function's return
   value is not tested for NULL, which might crash the
   interpreter.

2. Objects/funcobjects.c: function_call():
   the Py_DECREF(arg) after PyErr_NoMemory() should be
   removed

3. Python/ceval.c: unpack_iterable():
   in the path through the error "too many values to
   unpack", a Py_DECREF(w) is missing

4. Python/ceval.c: apply_slice():
   the slice object returned by PySlice_New() is never
   Py_DECREF'ed.

5. Python/ceval.c: assign_slice():
   the slice object returned by PySlice_New() is never
   Py_DECREF'ed.

[tim-one]

Logged In: YES
user_id=31435

Boosted priority.

[gvanrossum]

Logged In: YES
user_id=6380

I'll have a look at these.

[gvanrossum]

Logged In: YES
user_id=6380

Thanks, Armin. I'd be interested in finding out which tool
you used to find these!

• Item Support "bpo-" in Misc/NEWS #1 is no longer current; this was solved by not
  calling PyObject_Repr(func) at all (which has all sorts of
  other bad potential implications, so it's best not to call
  it for the purpose of creating friendly error messages).

• Item Rename README to README.rst and enhance formatting #2: Good catch. Must've been a remnant of a
  transformation long ago, when this code was moved from an
  in-line position in ceval.c to a separate function. Fixed
  in cvs, funcobject.c:2.48.

• Item bpo-29403: Fix mock's broken autospec behavior on method-bound builtin functions #3: Good job again. Fixed in ceval.c:2.292. I've
  added a test case too, test_iter.py:1.23.

• Items Update Python Software Foundation Copyright Year. #4 and Convert READMEs to rst #5: Right. Fixed in ceval.c:2.293.

This concludes this bug report. Closing as Fixed.