fixed handling of nested comments in mail addresses

[wamcvey]

BPO	1464708
Nosy	@warsaw
Files	getaddresses-nested-comment-patch: patch to fix bug and add testcase for embedded comment in email address bug getaddresses-nested-comment-rfc822-patch: patch to fix bug and add testcase for rfc822.py module

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/warsaw'
closed_at = <Date 2006-04-30.21:27:44.000>
created_at = <Date 2006-04-05.06:35:58.000>
labels = ['library']
title = 'fixed handling of nested  comments in mail addresses'
updated_at = <Date 2006-04-30.21:27:44.000>
user = 'https://bugs.python.org/wamcvey'

bugs.python.org fields:

activity = <Date 2006-04-30.21:27:44.000>
actor = 'barry'
assignee = 'barry'
closed = True
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2006-04-05.06:35:58.000>
creator = 'wamcvey'
dependencies = []
files = ['7141', '7142']
hgrepos = []
issue_num = 1464708
keywords = ['patch']
message_count = 6.0
messages = ['49967', '49968', '49969', '49970', '49971', '49972']
nosy_count = 3.0
nosy_names = ['barry', 'nnorwitz', 'wamcvey']
pr_nums = []
priority = 'normal'
resolution = 'accepted'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue1464708'
versions = ['Python 2.4']

[wamcvey]

RFC 2822 allows for comments to include other comments
in a mail address. email.Utils.getaddresses() handled
addresses with a comment, but incorrectly advanced the
parsing index twice after a comment finished. This
would cause the outer closing paren in an address like:
Foo ((FOO Rocks)) <foo@bar.com>
to be missed, and treating the rest of the line as part
of the outer comment.

This patch fixes the bug and adds a testcase to look
for the bug.

[wamcvey]

Logged In: YES
user_id=25956

hmm, didn't seem to attach my patch the first time. Let's
try adding it again.

[nnorwitz]

Logged In: YES
user_id=33168

Barry, has the new email addressed this?

[wamcvey]

Logged In: YES
user_id=25956

I just realized that I only submitted the patch for the
email package and that the same bug exists in the rfc822.py
package. Even though deprecated, I imagine bug fixes are
still appropriate, so I'm attaching a second attachment
which patch rfc822.py and adds a testcase for this condition
to test/test_rfc822.py. I also noticed that the testcase
driver in test_rfc822.py emitted a print statement error but
didn't raise a condition when the parsed name or address
differed from the expected name. I've adjusted the driver to
use assertions so that the error condition are more
noticeable (e.g. error status codes).

[wamcvey]

Logged In: YES
user_id=25956

I see now that there appears to be duplicate patches against
the email package attached. I'll go ahead and remove the
duplicate, leaving one patch for email package and one patch
for rfc822.py.

Oh, and it probably goes without saying, but the first patch
is relative to the 'email' package directory and the second
is relative to the Lib directory in which rfc822.py is located.

[warsaw]

Logged In: YES
user_id=12800

Applied to Python 2.4 for email 3.0 in r45829. This needs
to be back ported to Python 2.3 for email 2.5 and forward
ported to Python 2.5 for email 4.0.