syslog syscall support for SysLogLogger

[luke-jr]

BPO	1711603
Nosy	@vsajip
Files	SysLogHandler-syslog-0.04.patch: syslog support (svn trunk)

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2007-09-27.06:19:25.719>
created_at = <Date 2007-05-03.00:12:14.000>
labels = ['library']
title = 'syslog syscall support for SysLogLogger'
updated_at = <Date 2009-06-22.14:56:55.348>
user = 'https://bugs.python.org/luke-jr'

bugs.python.org fields:

activity = <Date 2009-06-22.14:56:55.348>
actor = 'LwarX'
assignee = 'none'
closed = True
closed_date = <Date 2007-09-27.06:19:25.719>
closer = 'vinay.sajip'
components = ['Library (Lib)']
creation = <Date 2007-05-03.00:12:14.000>
creator = 'luke-jr'
dependencies = []
files = ['7981']
hgrepos = []
issue_num = 1711603
keywords = ['patch']
message_count = 29.0
messages = ['52554', '52555', '52556', '52557', '52558', '52559', '52560', '52561', '52562', '52563', '52564', '52565', '52566', '52567', '52568', '52569', '52570', '52571', '52572', '52573', '52574', '52575', '56157', '56160', '89594', '89595', '89598', '89600', '89601']
nosy_count = 4.0
nosy_names = ['vinay.sajip', 'josm', 'luke-jr', 'LwarX']
pr_nums = []
priority = 'normal'
resolution = 'rejected'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue1711603'
versions = []

[luke-jr]

This allows SysLogLogger to be used via the normal syslog syscall.

[luke-jr]

File Added: SysLogHandler-syslog-0.02.patch

[luke-jr]

File Added: SysLogHandler-syslog-0.03.patch

[josm]

What advantage does OS's syslog have over the logging module's one?
I've never been familiar with syslog,
So could you please tell me the difference?

[luke-jr]

Not all syslog daemons accept socket connections. For example, metalog.

[josm]

Thank you for your reply.

A few more comments and requests.

+ def __init__(self, address=('localhost', SYSLOG_UDP_PORT), facility=LOG_USER, ident=sys.argv[0]):

Why sys.argv[0]? Assuming command line arguments doesn't look reasonable to me.

+ self.unixsocket = 0
+ self.syscall = 0

Please use single-tab indents. (PEP-7)

Can I have the patch patch against the svn repository?
(against trunk should be preferable)
I had some problem applying your patch.

[luke-jr]

The 'ident' value is normally the name of the program, which should be argv[0]. I prefer and normally use single-tab indents. However, when patching code, I adjust to the existing standard within the source. In this case, my handlers.py was already indented with spaces so I conformed to that. I glanced at svn before posting this, and it doesn't appear to be much different for this file.

[luke-jr]

File Added: SysLogHandler-syslog-0.04.patch

[josm]

Sorry, I quoted wrong PEP... PEP-7 is for C code, not Python's one.
PEP-8 is right guide.

I'm still wondering whether using sys.argv[0] for default value is valid or not.
How about changing this as ident = 'syslog'?
doesn't that work?

[luke-jr]

No, 'syslog' wouldn't work because the running program's name is not 'syslog'. It should be the same name as appears in the process list, which is argv[0]

[josm]

Now I understand. Thank you for your patience :)

BTW, wouldn't it be nice to do os.path.basename() on ident?

[luke-jr]

Yes, that might be a sane thing to add :)
That exact problem bit me a few days ago, actually (I'm using this code already).

[vsajip]

The use of syslog is system-specific - there is no syslog syscall on Windows.

[luke-jr]

There is no syslog on Windows period. I guess you'd better remove chmod support from Python as well-- Windows doesn't use UNIX permissions! The whole purpose of this module is to log to syslog; the standard way for this is via a syscall. Not supporting the syscall kindof defeats the purpose.