py3k: compilation with VC2005

[amauryfa]

BPO	1031
Nosy	@amauryfa
Files	vc2005.diff vc2005-2.diff

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2007-08-26.23:48:22.066>
created_at = <Date 2007-08-26.22:12:08.073>
labels = ['build', 'OS-windows']
title = 'py3k: compilation with VC2005'
updated_at = <Date 2007-08-26.23:48:22.065>
user = 'https://github.com/amauryfa'

bugs.python.org fields:

activity = <Date 2007-08-26.23:48:22.065>
actor = 'nnorwitz'
assignee = 'nnorwitz'
closed = True
closed_date = <Date 2007-08-26.23:48:22.066>
closer = 'nnorwitz'
components = ['Windows']
creation = <Date 2007-08-26.22:12:08.073>
creator = 'amaury.forgeotdarc'
dependencies = []
files = ['8327', '8328']
hgrepos = []
issue_num = 1031
keywords = []
message_count = 7.0
messages = ['55315', '55316', '55319', '55320', '55322', '55326', '55327']
nosy_count = 2.0
nosy_names = ['nnorwitz', 'amaury.forgeotdarc']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = 'compile error'
url = 'https://bugs.python.org/issue1031'
versions = ['Python 3.0']

[amauryfa]

This patch is necessary to compile inside the PCBuild8 directory

[nnorwitz]

Thanks for the patch. I tried to apply this patch, but almost
everything failed. Could you make sure to do a svn update and then
generate the patch?

The only part of the patch that applied cleanly was to rmpyc.py. That
was checked in as:
Committed revision 57527.

[amauryfa]

Sorry, it's probably because I somehow converted the line endings.
Attached a new version of the patch.

[nnorwitz]

Hmmm, the patch was out of date (I had already removed cPickle).
However, I don't think that was the reason for everything failing. I
manually applied the changes to the files and python version. Things
should be pretty good now. I didn't add the libraries. I'm not sure
why they are needed now while they weren't necessary before.

Committed revision 57529.

[nnorwitz]

I thought it might be line endings so I tried changing them, but that
didn't help. I couldn't apply the new version of the patch either. I'm
not sure if the problem is on your side or mine. :-(

I missed some files from the original checkin. The new one hopefully
has all the files and is just missing the libraries. Can you svn update
and look at the new differences? Thanks.

Committed revision 57530.

[amauryfa]

Yes, everything compiles now.
I discovered that the additional libraries not necessary if I update my
VC 2005 Express installation as in this post:
http://forums.microsoft.com/MSDN/ShowPost.aspx?PostID=133236&SiteID=1

The problem is that the default installation of VS 8 express
doesn't support the Platform SDK, so, after installing the
platform SDK, you need to make a few modifications...

1. Update the corewin_express.vsprops file (NOT the
   corewin.vsprops file).
   (In the c:/Program Files/Microsoft Visual Studio 8/VC/VCProjectDefaults/
   directory)
   You need to change this...

AdditionalDependencies="kernel32.lib"

to this

AdditionalDependencies="kernel32.lib user32.lib gdi32.lib winspool.lib
comdlg32.lib advapi32.lib shell32.lib ole32.lib oleaut32.lib uuid.lib"

And everything compiles fine without further modification. Thanks!

[nnorwitz]

Awesome! I'm going to close this patch. Let me know if you have any
more problems. Feel free to send messages to python-3000. I would like
py3k to build on Windows for the alpha which will be coming out in about
a week hopefully.