tkinter Menu.delete bug

[skomoroh]

BPO	3774
Nosy	@loewis, @benjaminp
Files	menu_bug.py menu_bag.patch issue3774.diff menu_fix.patch issue3774_2.diff

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2008-11-03.18:20:28.033>
created_at = <Date 2008-09-04.13:19:15.108>
labels = ['easy', 'expert-tkinter']
title = 'tkinter Menu.delete bug'
updated_at = <Date 2008-11-04.06:28:19.179>
user = 'https://bugs.python.org/skomoroh'

bugs.python.org fields:

activity = <Date 2008-11-04.06:28:19.179>
actor = 'ocean-city'
assignee = 'none'
closed = True
closed_date = <Date 2008-11-03.18:20:28.033>
closer = 'ocean-city'
components = ['Tkinter']
creation = <Date 2008-09-04.13:19:15.108>
creator = 'skomoroh'
dependencies = []
files = ['11373', '11375', '11476', '11477', '11479']
hgrepos = []
issue_num = 3774
keywords = ['patch', 'easy']
message_count = 24.0
messages = ['72501', '72502', '72508', '73084', '73085', '73090', '73091', '73093', '73094', '73099', '73101', '73102', '73103', '73108', '73119', '73123', '73297', '74122', '74130', '74139', '75474', '75475', '75478', '75490']
nosy_count = 8.0
nosy_names = ['loewis', 'svenil', 'ocean-city', 'benjamin.peterson', 'gpolo', 'schuppenies', 'skomoroh', 'indiedan']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue3774'
versions = ['Python 2.6', 'Python 2.5', 'Python 3.0', 'Python 2.7']

[skomoroh]

When I create a menu item without command and them remove it, I have a
error:
File "/usr/local/lib/python3.0/tkinter/init.py", line 2661, in delete
if c in self._tclCommands:
TypeError: argument of type 'NoneType' is not iterable

[ocean-city]

I tried, and I confirmed released python2.5.2 runs fine. and
py3k, trunk, release25-maint fails. Probably something changed after
2.5.2 release.

[ocean-city]

I've not tested this so heavily, but patch could be simple.
self._tclCommands could be None, so should check it.

[indiedan]

Please forgive my rookie bug filing:

I'm getting this bug / crash sometimes when Menu.delete() is called too

It seems to be because self.index( ) sometimes returns None which is of
course un-iterable and delete() tries to iterate through it:

for i in range(self.index(index1), self.index(index2)+1):

As a fix the previous (simpler) delete works for me, but I don't
understand the purpose of the extra self.deletecommand() code appended
so I'm probably missing something.

My crash:
File "C:\CCPN\ccpn\python\memops\gui\Menu.py", line 127, in
deleteMenuItems
self.delete(0, Tkinter.END)
File "C:\Python26\lib\lib-tk\Tkinter.py", line 2665, in delete
for i in range(self.index(index1), self.index(index2)+1):
TypeError: unsupported operand type(s) for +: 'NoneType' and 'int'

[ocean-city]

for i in range(self.index(index1), self.index(index2)+1):

Probably your working copy is bit old. Please try latest file.
This issue was fixed in r65971. :-)

# I've added nosy list from bpo-1342811.

[gpolo]

Python 2.6b2 was released with this bug, and got fixed later.

[gpolo]

I meant beta3, sorry.

[gpolo]

Oops, sorry, I misread the bug report, reopening it (let me go eat
something now).

[indiedan]

Thanks guys - I was running an old build. revision 65971 fixed this as Hirokazu mentioned.