MacPython build script uses Carbon and MacOS modules slated for removal

[janssen]

BPO	4848
Nosy	@ronaldoussoren
Files	patch-seticon.txt

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/ronaldoussoren'
closed_at = <Date 2009-03-30.17:20:50.222>
created_at = <Date 2009-01-05.17:15:57.063>
labels = ['OS-mac', 'type-feature', 'build']
title = 'MacPython build script uses Carbon and MacOS modules slated for removal'
updated_at = <Date 2009-03-30.17:20:50.221>
user = 'https://bugs.python.org/janssen'

bugs.python.org fields:

activity = <Date 2009-03-30.17:20:50.221>
actor = 'ronaldoussoren'
assignee = 'ronaldoussoren'
closed = True
closed_date = <Date 2009-03-30.17:20:50.222>
closer = 'ronaldoussoren'
components = ['Build', 'macOS']
creation = <Date 2009-01-05.17:15:57.063>
creator = 'janssen'
dependencies = []
files = ['13243']
hgrepos = []
issue_num = 4848
keywords = []
message_count = 5.0
messages = ['79169', '83153', '83161', '83178', '84582']
nosy_count = 2.0
nosy_names = ['ronaldoussoren', 'janssen']
pr_nums = []
priority = 'low'
resolution = 'accepted'
stage = None
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue4848'
versions = ['Python 2.6', 'Python 3.0', 'Python 3.1', 'Python 2.7']

[janssen]

The build script for a Mac OS installer, in
Mac/BuildScript/build-installer.py, currently requires OS 10.4 and
Python 2.3. At some point it will have to be ported to a newer version
of Python (and Mac OS). It uses a number of modules which are slated
for future removal, particularly Carbon and MacOS. These modules are
only used in the function "setIcon". They can be replaced with a call
to a Cocoa method via PyObjC. The "setIcon" function using PyObjC would
look like this:

def setIcon(folder, imagefile):

try:

        import os, AppKit

        AppKit.NSApplicationLoad()      # initialize Cocoa

        return
AppKit.NSWorkspace.sharedWorkspace().setIcon_forFile_options_(
            AppKit.NSImage.alloc().initWithContentsOfFile_(imagefile),
            os.path.abspath(folder), 0)

    except ImportError:
        return False

[ronaldoussoren]

Usage of PyObjC in the build-script should be avoided, as should eating
exceptions like you propose. The rationale for not silencing exceptions is
that the build script is supposed to enable reproducable builds.

I'll probably add a small Cocoa ObjC program to the BuildScript directory
that uses the API's you mention.

[ronaldoussoren]

The attached patch shows what I intent do commit after testing. This adds
a small ObjC command-line tool that sets the icon. I still have to build
the installer to check if the patch actually works.

[janssen]

Looks good. The contrast is stark.

[ronaldoussoren]

Fixed in r70727 (trunk), r70728 (2.6) and r70729 (3.1)