New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PyArg_ParseTuple y* documentation is incorrect #53404
Comments
The documented C type for y* should be [Py_buffer], not [Py_buffer *], as with the documentation for z* and the convention followed by the other types. I'm not sure what 'type' this issue should have. I've set it at 'crash' initially, since that's how the bug manifested for me. |
y* and z* result is a Py_buffer, but in C you have to pass a reference to the result variable using &result. Full example: static PyObject *
getargs_y_star(PyObject *self, PyObject *args)
{
Py_buffer buffer;
PyObject *bytes;
if (!PyArg_ParseTuple(args, "y*", &buffer))
return NULL;
bytes = PyBytes_FromStringAndSize(buffer.buf, buffer.len);
PyBuffer_Release(&buffer);
return bytes;
} Another example: "s" format result is char* (and not char**). You also have to pass a reference using &: static PyObject *
getargs_s(PyObject *self, PyObject *args)
{
char *str;
if (!PyArg_ParseTuple(args, "s", &str))
return NULL;
return PyBytes_FromString(str);
} |
@victor: "y* and z* result is a Py_buffer" Correct, so why is z* documented as [Py_buffer] and y* documented as [Py_buffer*]? If I make 'buffer' from your example a Py_buffer*, as documented, then python puts writes sizeof(Py_buffer) bytes into a random spot in memory. Thus the attached patch. Thanks for giving this a look, but I don't think this issue is closed -- the documentation for y* is still wrong. |
Oh ok, sorry. Fixed in r82597 (3.x) and r82598 (3.1). |
Awesome! Thanks, and sorry for communicating the problem so poorly initially. |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
bugs.python.org fields:
The text was updated successfully, but these errors were encountered: