test_socket.testDup, testFromFd fail on Windows

[stutzbach]

BPO	9753
Nosy	@amauryfa, @tiran, @tjguk, @briancurtin
Files	issue9753.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2010-09-03.12:43:05.760>
created_at = <Date 2010-09-03.10:16:05.535>
labels = ['type-bug', 'library', 'OS-windows']
title = 'test_socket.testDup, testFromFd fail on Windows'
updated_at = <Date 2010-09-03.12:43:05.758>
user = 'https://bugs.python.org/stutzbach'

bugs.python.org fields:

activity = <Date 2010-09-03.12:43:05.758>
actor = 'stutzbach'
assignee = 'stutzbach'
closed = True
closed_date = <Date 2010-09-03.12:43:05.760>
closer = 'stutzbach'
components = ['Library (Lib)', 'Windows']
creation = <Date 2010-09-03.10:16:05.535>
creator = 'stutzbach'
dependencies = []
files = ['18724']
hgrepos = []
issue_num = 9753
keywords = ['patch']
message_count = 7.0
messages = ['115432', '115438', '115439', '115440', '115442', '115443', '115448']
nosy_count = 6.0
nosy_names = ['amaury.forgeotdarc', 'christian.heimes', 'tim.golden', 'roudkerk', 'stutzbach', 'brian.curtin']
pr_nums = []
priority = 'normal'
resolution = 'accepted'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue9753'
versions = ['Python 3.1', 'Python 3.2']

[stutzbach]

The errors below show up on my XP machine in Python 3.1 as well as a recent build from the py3k branch. I'm not sure why they *don't* show up on the XP buildbot.

fromfd() ultimately calls dup(), so the underlying problem is likely the same for all the failures. dup() support was added for Windows in bpo-1378.

======================================================================
ERROR: testDup (test.test_socket.BasicTCPTest)
----------------------------------------------------------------------

Traceback (most recent call last):
  File "C:\Python31\lib\test\test_socket.py", line 628, in testDup
    msg = sock.recv(1024)
socket.error: [Errno 10038] An operation was attempted on something that is not a socket

======================================================================
ERROR: testFromFd (test.test_socket.BasicTCPTest)
----------------------------------------------------------------------

Traceback (most recent call last):
  File "C:\Python31\lib\test\test_socket.py", line 619, in testFromFd
    msg = sock.recv(1024)
socket.error: [Errno 10038] An operation was attempted on something that is not a socket

======================================================================
ERROR: testDup (test.test_socket.BasicTCPTest2)
----------------------------------------------------------------------

Traceback (most recent call last):
  File "C:\Python31\lib\test\test_socket.py", line 628, in testDup
    msg = sock.recv(1024)
socket.error: [Errno 10045] The attempted operation is not supported for the type of object referenced

======================================================================
ERROR: testFromFd (test.test_socket.BasicTCPTest2)
----------------------------------------------------------------------

Traceback (most recent call last):
  File "C:\Python31\lib\test\test_socket.py", line 619, in testFromFd
    msg = sock.recv(1024)
socket.error: [Errno 10038] An operation was attempted on something that is not a socket

---

[amauryfa]

test_socket.py passes here.
I run: python_d.exe -m test.regrtest -v test_socket

[stutzbach]

I run it the same way.

I wonder what's different? :-( I will try to find some time to investigate further.

[stutzbach]

On Windows, socket.dup is implemented using DuplicateHandle. The documentation for DuplicateHandle reads:

You should not use DuplicateHandle to duplicate handles to the following objects:

* I/O completion ports. No error is returned, but the duplicate handle cannot be used.
* Sockets. No error is returned, but the duplicate handle may not be recognized by Winsock at the target process. Also, using DuplicateHandle interferes with internal reference counting on the underlying object. To duplicate a socket handle, use the WSADuplicateSocket function.

[stutzbach]

Following the advice of DuplicateHandle's documentation, I reimplemented dup on Windows using WSADuplicateHandle. Attached is a patch. With the patch, the tests pass on my Windows machine.

Would someone like to review the patch?

[amauryfa]

The documentation of WSASocket(), and the code of PyBluez
http://code.google.com/p/pybluez/source/browse/trunk/msbt/_msbt.c#374
both suggest to use the FROM_PROTOCOL_INFO constant.
Otherwise, the patch looks good.

[stutzbach]

Thanks! Updated as you suggested and committed as r84450 and r84451.