duplicate test names in Lib/ctypes/test/test_functions.py

[xdegaye]

BPO	19113
Nosy	@amauryfa, @abalkin, @ezio-melotti, @meadori, @xdegaye, @ambv, @shihai1991, @FFY00, @furkanonder, @akulakov
PRs	bpo-19113: remove unused test_errors #28008

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2021-09-08.15:32:29.740>
created_at = <Date 2013-09-28.16:23:39.471>
labels = ['type-bug', 'library', '3.11']
title = 'duplicate test names in Lib/ctypes/test/test_functions.py'
updated_at = <Date 2021-09-08.15:32:29.739>
user = 'https://github.com/xdegaye'

bugs.python.org fields:

activity = <Date 2021-09-08.15:32:29.739>
actor = 'lukasz.langa'
assignee = 'none'
closed = True
closed_date = <Date 2021-09-08.15:32:29.740>
closer = 'lukasz.langa'
components = ['Library (Lib)']
creation = <Date 2013-09-28.16:23:39.471>
creator = 'xdegaye'
dependencies = []
files = []
hgrepos = []
issue_num = 19113
keywords = ['patch']
message_count = 8.0
messages = ['198529', '227985', '228060', '340115', '348245', '366674', '401391', '401392']
nosy_count = 10.0
nosy_names = ['amaury.forgeotdarc', 'belopolsky', 'ezio.melotti', 'meador.inge', 'xdegaye', 'lukasz.langa', 'shihai1991', 'FFY00', 'furkanonder', 'andrei.avk']
pr_nums = ['28008']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue19113'
versions = ['Python 3.11']

[xdegaye]

After renaming the first test_errors method to test_errors_1 and the
second one to test_errors_2:

$ /bin/sh -c "cd Lib/ctypes/test; ../../../python runtests.py test_functions.py"
....F................

======================================================================
FAIL: test_errors_1 (ctypes.test.test_functions.FunctionTestCase)
----------------------------------------------------------------------

Traceback (most recent call last):
  File "./Lib/ctypes/test/test_functions.py", line 227, in test_errors_1
    self.assertRaises(TypeError, f, X()) #cannot convert parameter
AssertionError: TypeError not raised by _testfunc_p_p

---

Ran 21 tests in 0.007s

FAILED (failures=1)

[BreamoreBoy]

@xavier can you provide a patch for this issue?

[xdegaye]

This issue has been entered while checking for duplicate test names in bpo-16079.

[xdegaye]

Still fails on Python 3.8.0a3+.

[shihai1991]

en, in python 3.8.0a3, I got those other error info:

$ /home/shihai/workspace/cpython/python test_functions.py

ERROR:root:code for hash md5 was not found.
Traceback (most recent call last):
  File "/home/shihai/workspace/cpython/Lib/hashlib.py", line 244, in <module>
    globals()[__func_name] = __get_hash(__func_name)
  File "/home/shihai/workspace/cpython/Lib/hashlib.py", line 113, in __get_builtin_constructor
    raise ValueError('unsupported hash type ' + name)
ValueError: unsupported hash type md5

but in master branch, the test case is ok.

[furkanonder]

There are two tests with same name in the same test class (ctypes.test.test_functions test_errors)
After merging both and re-run I encounter with this error
which looks like it was always there but overwritten by other test (with same name)

....F...........s.s...
======================================================================
FAIL: test_errors (main.FunctionTestCase)
----------------------------------------------------------------------

Traceback (most recent call last):
  File "/home/furkan/cpython/Lib/ctypes/test/test_functions.py", line 219, in test_errors
    self.assertRaises(TypeError, f, X()) #cannot convert parameter
AssertionError: TypeError not raised by _testfunc_p_p

---

Ran 22 tests in 0.003s

[ambv]

New changeset a561005 by andrei kulakov in branch 'main':
bpo-19113: Remove unused test_errors from ctypes tests (GH-28008)
a561005

[ambv]

Change made in Python 3.11: duplicate test removed. Closing.