smtpd.py (SMTPChannel): implement enhanced status codes

[lpolzer]

BPO	19679
Nosy	@warsaw, @bitdancer

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2018-01-10.00:57:15.087>
created_at = <Date 2013-11-21.10:59:58.962>
labels = ['type-feature', 'library', 'expert-email']
title = 'smtpd.py (SMTPChannel): implement enhanced status codes'
updated_at = <Date 2018-01-10.00:57:15.086>
user = 'https://bugs.python.org/lpolzer'

bugs.python.org fields:

activity = <Date 2018-01-10.00:57:15.086>
actor = 'barry'
assignee = 'none'
closed = True
closed_date = <Date 2018-01-10.00:57:15.087>
closer = 'barry'
components = ['Library (Lib)', 'email']
creation = <Date 2013-11-21.10:59:58.962>
creator = 'lpolzer'
dependencies = []
files = []
hgrepos = []
issue_num = 19679
keywords = []
message_count = 8.0
messages = ['203610', '203622', '204361', '204371', '204384', '204396', '204514', '309757']
nosy_count = 3.0
nosy_names = ['barry', 'r.david.murray', 'lpolzer']
pr_nums = []
priority = 'normal'
resolution = 'wont fix'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue19679'
versions = ['Python 3.5']

[lpolzer]

ESMTP status messages (of the form "xab x.y.z test") can be added easily to the current status message strings emitted by the SMTP server and channel classes. They are not harmful if the user's server only intends to support plain HELO-SMTP

I will provide a patch within due time unless someone disagrees.

[lpolzer]

The contents of "conn" are already stored by asyncore's "socket" attribute, so there doesn't seem to be a need to keep it around. We should deprecate its usage and refer the user to the "socket" attribute.

Furthermore I suggest renaming the "conn" argument to "socket" to make its semantics clearer.

[bitdancer]

Are you referring to implementing rfc 3463 and rfc 5248 insofar as they are applicable? That seems useful. I don't see anything in the RFC about the 'xab x.y.z text' form of the message, though. Where is that documented? IMO these messages should only be emitted if we got an ELHO...actually I would expect there to be an extension keyword associated with this, but I don't see one in the RFC.

The conn argument is a separate issue. (And probably should not change for backward compatibility reasons. Also, it doesn't have to be a socket, although it would indeed be unusual if it wasn't.)

[lpolzer]

Sorry for the confusion, the second comment (#msg203622) should actually have been a separate ticket.

Since you'd like to preserve "conn" I will just change the title of this ticket.

[lpolzer]

I am indeed referring to the enhanced status codes proposed in RFC 3463. This would just entail adding information to the status codes, converting them from the format "<simple status code> <human-readable string>" to "<simple status code> <enhanced status code> <human-readable string>".

In this it doesn't seem necessary to differentiate by HELO/EHLO; neither is it demanded by the standard nor does it result in an incompatible form of traditional HELO status messages. HELO clients should just interpret the first three digits and regard the rest as part of the human readable informal section.

[bitdancer]

"Should" and "do" are different, though. I wouldn't be at all surprised to find legacy code that did look at the text string part of the message. Particularly test code, which is a place that smtpd gets used commonly.

Which probably means that what we really need is a keyword argument to the SMTPServer constructor (analogous to data_size_limit) that indicates whether or not enhanced status codes are enabled, and have it be off by default. If desired, we could then issue a warning that enhanced status codes will be enabled by default in 3.6. That kind of process is our usual backward-compatibility dance. In this particular instance we could go one step farther and add a deprecation warning in 3.6 that the ability to set enhanced status codes off will go away in 3.7. If anybody remembers to carry through on it :)

[lpolzer]

Sounds reasonable, I will propose a patch soon. Thanks!

[warsaw]

I'm closing this as won't fix since smtpd.py is deprecated and will likely not get any future development. Please see aiosmtpd as a much better third party replacement.