Provide samefile() on Path objects

[pitrou]

BPO	19775
Nosy	@gvanrossum, @pitrou, @vstinner, @vajrasky
Files	pathlib_samefile.patch pathlib_samefile_v2.patch pathlib_samefile_v3.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2014-05-13.08:55:56.570>
created_at = <Date 2013-11-25.19:48:21.236>
labels = ['type-feature', 'library']
title = 'Provide samefile() on Path objects'
updated_at = <Date 2014-05-13.08:55:56.570>
user = 'https://github.com/pitrou'

bugs.python.org fields:

activity = <Date 2014-05-13.08:55:56.570>
actor = 'pitrou'
assignee = 'none'
closed = True
closed_date = <Date 2014-05-13.08:55:56.570>
closer = 'pitrou'
components = ['Library (Lib)']
creation = <Date 2013-11-25.19:48:21.236>
creator = 'pitrou'
dependencies = []
files = ['32916', '32927', '32979']
hgrepos = []
issue_num = 19775
keywords = ['patch']
message_count = 9.0
messages = ['204386', '204639', '204880', '204887', '204923', '205263', '205270', '218413', '218415']
nosy_count = 6.0
nosy_names = ['gvanrossum', 'pitrou', 'vstinner', 'Arfrever', 'python-dev', 'vajrasky']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue19775'
versions = ['Python 3.5']

[pitrou]

It would probably be useful to provide samefile() on Path objects - basically doing the same thing as os.path.samefile().

[vstinner]

I like the idea :-)

[vajrasky]

Here is the patch.

[Arfrever]

About doc string in patch:

1. s/same/the same/
2. "same" is usually used with "as", not "with":
   https://books.google.com/ngrams/graph?content=same+as%2Csame+with%2Csame+to&year_start=1800&year_end=2000&corpus=15&smoothing=3

[vajrasky]

Updated grammar according to Arfrever's review. Thanks!

Anyway, should samefile accepts only string? Or should it accept Path object as well?

[pitrou]

Thanks for the patch! Some comments:

1. It should path objects as well as str objects.
2. I don't think you have to call resolve() here.
3. you should probably test what happens when one of the files doesn't exist
4. you need to update the documentation too

[vajrasky]

Thanks for the review!

Attached the patch addressing the request by Antoine.

[pitrou]

Sorry, it seems I have let this issue slip. I will update the patch and commit it soon!

[python-dev]

New changeset 197ac5d79456 by Antoine Pitrou in branch 'default':
Issue bpo-19775: Add a samefile() method to pathlib Path objects.
http://hg.python.org/cpython/rev/197ac5d79456