out of memory in distutils.upload with large files

[JanStrtz]

BPO	24691
Nosy	@merwok, @zooba, @dstufft

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2021-02-03.18:19:29.100>
created_at = <Date 2015-07-23.09:44:12.955>
labels = ['library', 'performance']
title = 'out of memory in distutils.upload with large files'
updated_at = <Date 2021-02-03.18:19:29.099>
user = 'https://bugs.python.org/JanStrtz'

bugs.python.org fields:

activity = <Date 2021-02-03.18:19:29.099>
actor = 'steve.dower'
assignee = 'none'
closed = True
closed_date = <Date 2021-02-03.18:19:29.100>
closer = 'steve.dower'
components = ['Distutils']
creation = <Date 2015-07-23.09:44:12.955>
creator = 'Jan.St\xc3\xbcrtz'
dependencies = []
files = []
hgrepos = []
issue_num = 24691
keywords = []
message_count = 2.0
messages = ['247179', '386340']
nosy_count = 4.0
nosy_names = ['eric.araujo', 'Jan.St\xc3\xbcrtz', 'steve.dower', 'dstufft']
pr_nums = []
priority = 'normal'
resolution = 'out of date'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'resource usage'
url = 'https://bugs.python.org/issue24691'
versions = ['Python 2.7']

[JanStrtz]

We tried to upload a very large (350MB) bdist egg via distutils to our internal package server.
And received following crash.

Traceback (most recent call last):
  File "setup.py", line 1, in <module>
    import os
  File "C:\devel\cdb\10.1.tag\cdb\python\cdb\comparch\pkgtools.py", line 120, in setup
    def setup(**kwargs):
  File "C:\devel\cdb\10.1.tag\win32\debug\img\lib\distutils\core.py", line 60, in setup
    def setup(**attrs):
  File "C:\devel\cdb\10.1.tag\win32\debug\img\lib\distutils\dist.py", line 947, in run_commands
    def run_commands(self):
  File "C:\devel\cdb\10.1.tag\win32\debug\img\lib\distutils\dist.py", line 957, in run_command
    def run_command(self, command):
  File "C:\devel\cdb\10.1.tag\win32\debug\img\lib\distutils\command\upload.py", line 56, in run
    def run(self):
  File "C:\devel\cdb\10.1.tag\win32\debug\img\lib\distutils\command\upload.py", line 154, in upload_file
    body.write('\r\nContent-Disposition: form-data; name="%s"' % key)
MemoryError: out of memory

A patch could be very easy using tempfile.SpooledTemporaryFile()

[zooba]

Distutils is now deprecated (see PEP-632) and all tagged issues are being closed. From now until removal, only release blocking issues will be considered for distutils.

If this issue does not relate to distutils, please remove the component and reopen it. If you believe it still requires a fix, most likely the issue should be re-reported at https://github.com/pypa/setuptools