Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

android does not have pwd.getpwall() #71043

Closed
xdegaye mannequin opened this issue Apr 26, 2016 · 7 comments
Closed

android does not have pwd.getpwall() #71043

xdegaye mannequin opened this issue Apr 26, 2016 · 7 comments
Assignees
Labels
3.7 build The build process and cross-build stdlib Python modules in the Lib dir tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error

Comments

@xdegaye
Copy link
Mannequin

xdegaye mannequin commented Apr 26, 2016

BPO 26856
Nosy @xdegaye, @Fak3, @moreati
PRs
  • bpo-26856: Skip test_pwd on Android until issue 32033 is fixed #4561
  • Dependencies
  • bpo-27027: add the 'is_android' attribute to test.support
  • bpo-32033: The pwd module implementation incorrectly sets some attributes to None
  • Files
  • pwd.patch
  • pwd_2.patch
  • pwd_3.patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/xdegaye'
    closed_at = None
    created_at = <Date 2016-04-26.13:29:05.170>
    labels = ['3.7', 'tests', 'type-bug', 'library', 'build']
    title = 'android does not have pwd.getpwall()'
    updated_at = <Date 2017-11-25.16:33:07.817>
    user = 'https://github.com/xdegaye'

    bugs.python.org fields:

    activity = <Date 2017-11-25.16:33:07.817>
    actor = 'xdegaye'
    assignee = 'xdegaye'
    closed = False
    closed_date = None
    closer = None
    components = ['Library (Lib)', 'Tests', 'Cross-Build']
    creation = <Date 2016-04-26.13:29:05.170>
    creator = 'xdegaye'
    dependencies = ['27027', '32033']
    files = ['42608', '42913', '45855']
    hgrepos = []
    issue_num = 26856
    keywords = ['patch']
    message_count = 6.0
    messages = ['264279', '265919', '282975', '283082', '306962', '306966']
    nosy_count = 4.0
    nosy_names = ['xdegaye', 'python-dev', 'Roman.Evstifeev', 'Alex.Willmer']
    pr_nums = ['4561']
    priority = 'normal'
    resolution = None
    stage = None
    status = 'open'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue26856'
    versions = ['Python 3.6', 'Python 3.7']

    @xdegaye
    Copy link
    Mannequin Author

    xdegaye mannequin commented Apr 26, 2016

    User ids on android are the ids of the applications and they are used to enforce the applications access rights. See the 'User IDs and File Access' section at http://developer.android.com/guide/topics/security/permissions.html.

    Most integers are existing user ids on android. This may explain why getpwall() is missing.
    Patch attached.

    @xdegaye xdegaye mannequin added stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error build The build process and cross-build labels Apr 26, 2016
    @xdegaye
    Copy link
    Mannequin Author

    xdegaye mannequin commented May 20, 2016

    This new patch adds a dependency to issue bpo-27027.

    @xdegaye xdegaye mannequin added 3.7 tests Tests in the Lib/test dir labels Oct 28, 2016
    @xdegaye xdegaye mannequin self-assigned this Oct 28, 2016
    @xdegaye
    Copy link
    Mannequin Author

    xdegaye mannequin commented Dec 12, 2016

    Patch updated to the current head of the default branch.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Dec 13, 2016

    New changeset e89c9ab46d77 by Xavier de Gaye in branch '3.6':
    Issue bpo-26856: Fix the tests assuming that the pwd module has getpwall() and
    https://hg.python.org/cpython/rev/e89c9ab46d77

    New changeset 692083f85981 by Xavier de Gaye in branch 'default':
    Issue bpo-26856: Merge 3.6.
    https://hg.python.org/cpython/rev/692083f85981

    @xdegaye xdegaye mannequin closed this as completed Dec 13, 2016
    @xdegaye
    Copy link
    Mannequin Author

    xdegaye mannequin commented Nov 25, 2017

    The pwd module is broken when a member of the 'passwd’ data structure is NULL (bpo-32033).
    Remove _getpwall() and therefore skip test_pwd on Android until bpo-32033 is fixed.

    @xdegaye xdegaye mannequin reopened this Nov 25, 2017
    @xdegaye
    Copy link
    Mannequin Author

    xdegaye mannequin commented Nov 25, 2017

    New changeset 76fdac4 by xdegaye in branch 'master':
    bpo-26856: Skip test_pwd on Android until bpo-32033 is fixed (GH-4561)
    76fdac4

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    @kumaraditya303
    Copy link
    Contributor

    kumaraditya303 commented May 27, 2022

    Fixed by #4561

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.7 build The build process and cross-build stdlib Python modules in the Lib dir tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Development

    No branches or pull requests

    1 participant