Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comprehensions and await need more unittests #71355

Closed
njsmith opened this issue May 31, 2016 · 2 comments
Closed

Comprehensions and await need more unittests #71355

njsmith opened this issue May 31, 2016 · 2 comments
Assignees
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error

Comments

@njsmith
Copy link
Contributor

njsmith commented May 31, 2016

BPO 27168
Nosy @njsmith, @1st1

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = 'https://github.com/1st1'
closed_at = <Date 2016-10-05.23:46:50.967>
created_at = <Date 2016-05-31.18:06:54.667>
labels = ['interpreter-core', 'type-bug', 'tests']
title = 'Comprehensions and await need more unittests'
updated_at = <Date 2016-10-05.23:46:50.966>
user = 'https://github.com/njsmith'

bugs.python.org fields:

activity = <Date 2016-10-05.23:46:50.966>
actor = 'yselivanov'
assignee = 'yselivanov'
closed = True
closed_date = <Date 2016-10-05.23:46:50.967>
closer = 'yselivanov'
components = ['Interpreter Core', 'Tests']
creation = <Date 2016-05-31.18:06:54.667>
creator = 'njs'
dependencies = []
files = []
hgrepos = []
issue_num = 27168
keywords = []
message_count = 2.0
messages = ['266763', '278163']
nosy_count = 2.0
nosy_names = ['njs', 'yselivanov']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue27168'
versions = ['Python 3.5', 'Python 3.6']

@njsmith
Copy link
Contributor Author

njsmith commented May 31, 2016

So he asked me to file a bug reminding him to write more unit tests.

Interesting cases:

async def f():
    return (x for x in await g())

async def f():
    return (await x for x in g())

(and ditto for [], {} comprehensions)

@njsmith njsmith added the interpreter-core (Objects, Python, Grammar, and Parser dirs) label May 31, 2016
@SilentGhost SilentGhost mannequin added the tests Tests in the Lib/test dir label Jun 6, 2016
@SilentGhost SilentGhost mannequin changed the title Yury isn't sure comprehensions and await interact correctly Comprehensions and await need more unittests Jun 6, 2016
@SilentGhost SilentGhost mannequin added the type-bug An unexpected behavior, bug, or error label Jun 6, 2016
@1st1
Copy link
Member

1st1 commented Oct 5, 2016

Closing this one. We added a lot of tests as part of the PEP-530 implementation.

@1st1 1st1 closed this as completed Oct 5, 2016
@ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

No branches or pull requests

2 participants