Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add collections.abc.AsyncGenerator #72906

Closed
1st1 opened this issue Nov 16, 2016 · 4 comments
Closed

Add collections.abc.AsyncGenerator #72906

1st1 opened this issue Nov 16, 2016 · 4 comments
Assignees
Labels
3.7 release-blocker stdlib Python modules in the Lib dir type-feature A feature request or enhancement

Comments

@1st1
Copy link
Member

1st1 commented Nov 16, 2016

BPO 28720
Nosy @gvanrossum, @ned-deily, @1st1
Files
  • agen_abc.patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/1st1'
    closed_at = <Date 2016-11-16.23:26:07.662>
    created_at = <Date 2016-11-16.21:30:05.819>
    labels = ['3.7', 'type-feature', 'library', 'release-blocker']
    title = 'Add collections.abc.AsyncGenerator'
    updated_at = <Date 2016-11-16.23:26:32.019>
    user = 'https://github.com/1st1'

    bugs.python.org fields:

    activity = <Date 2016-11-16.23:26:32.019>
    actor = 'yselivanov'
    assignee = 'yselivanov'
    closed = True
    closed_date = <Date 2016-11-16.23:26:07.662>
    closer = 'yselivanov'
    components = ['Library (Lib)']
    creation = <Date 2016-11-16.21:30:05.819>
    creator = 'yselivanov'
    dependencies = []
    files = ['45513']
    hgrepos = []
    issue_num = 28720
    keywords = ['patch']
    message_count = 4.0
    messages = ['280993', '281003', '281012', '281013']
    nosy_count = 4.0
    nosy_names = ['gvanrossum', 'ned.deily', 'python-dev', 'yselivanov']
    pr_nums = []
    priority = 'release blocker'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue28720'
    versions = ['Python 3.6', 'Python 3.7']

    @1st1
    Copy link
    Member Author

    1st1 commented Nov 16, 2016

    This patch adds collections.abc.AsyncGenerator (closely modelled after collections.abc.Generator).

    Ned, is it OK if this goes into 3.6? This is something I completely forgot to do as part of PEP-525. This ABC is needed for asynchronous generators compiled with Cython and async-generator-like objects/wrappers.

    I'll update the PEP if we can push this to 3.6.

    @1st1 1st1 self-assigned this Nov 16, 2016
    @1st1 1st1 added stdlib Python modules in the Lib dir type-feature A feature request or enhancement labels Nov 16, 2016
    @ned-deily
    Copy link
    Member

    ned-deily commented Nov 16, 2016

    OK for 3.6.0b4

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Nov 16, 2016

    New changeset ae1dba7e7d04 by Yury Selivanov in branch '3.6':
    Issue bpo-28720: Add collections.abc.AsyncGenerator.
    https://hg.python.org/cpython/rev/ae1dba7e7d04

    New changeset fb9c8fdef3ec by Yury Selivanov in branch 'default':
    Merge 3.6 (issue bpo-28720)
    https://hg.python.org/cpython/rev/fb9c8fdef3ec

    @1st1 1st1 closed this as completed Nov 16, 2016
    @1st1
    Copy link
    Member Author

    1st1 commented Nov 16, 2016

    Thanks Ned. I went ahead and committed the patch.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.7 release-blocker stdlib Python modules in the Lib dir type-feature A feature request or enhancement
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants