Compiler failure on Mac OS X - sys/random.h

[PamMcANulty]

BPO	29057
Nosy	@rhettinger, @ronaldoussoren, @mdickinson, @vstinner, @larryhastings, @tiran, @benjaminp, @ned-deily, @gwk, @yan12125, @decibel
PRs	bpo-29176: Fix name of the _curses.window class #52
Files	Issue29057_random_include.patch Issue29057_random_include-v2.patch random.h issue29057.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/benjaminp'
closed_at = <Date 2017-01-19.23:10:31.477>
created_at = <Date 2016-12-23.17:37:29.671>
labels = ['OS-mac', 'build', '3.7', 'release-blocker']
title = 'Compiler failure on Mac OS X - sys/random.h'
updated_at = <Date 2017-01-19.23:10:31.476>
user = 'https://bugs.python.org/PamMcANulty'

bugs.python.org fields:

activity = <Date 2017-01-19.23:10:31.476>
actor = 'ned.deily'
assignee = 'benjamin.peterson'
closed = True
closed_date = <Date 2017-01-19.23:10:31.477>
closer = 'ned.deily'
components = ['Build', 'macOS']
creation = <Date 2016-12-23.17:37:29.671>
creator = 'Pam.McANulty'
dependencies = []
files = ['46009', '46024', '46108', '46109']
hgrepos = []
issue_num = 29057
keywords = ['patch']
message_count = 29.0
messages = ['283889', '283890', '283892', '283893', '283896', '283900', '283920', '283954', '283955', '284151', '284426', '284427', '284431', '284433', '284458', '284461', '284462', '284467', '284762', '284765', '284766', '285071', '285072', '285076', '285235', '285236', '285265', '285274', '285541']
nosy_count = 13.0
nosy_names = ['rhettinger', 'ronaldoussoren', 'mark.dickinson', 'vstinner', 'larry', 'christian.heimes', 'benjamin.peterson', 'ned.deily', 'python-dev', 'Pam.McANulty', 'gwk', 'yan12125', 'Jim Nasby']
pr_nums = ['52']
priority = 'release blocker'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'compile error'
url = 'https://bugs.python.org/issue29057'
versions = ['Python 2.7', 'Python 3.5', 'Python 3.6', 'Python 3.7']

[PamMcANulty]

make failed on Mac OS X including sys/random.h

It looks to be caused by this commit: 1958527

Restoring the removed ifdefs solves the problem (see github PR)

Official patch to follow

Failure message.

In file included from Python/random.c:16:
/usr/include/sys/random.h:37:32: error: unknown type name 'u_int'
void read_random(void* buffer, u_int numBytes);
                               ^
/usr/include/sys/random.h:38:33: error: unknown type name 'u_int'
void read_frandom(void* buffer, u_int numBytes);
                                ^
/usr/include/sys/random.h:39:33: error: unknown type name 'u_int'
int  write_random(void* buffer, u_int numBytes);
                                ^
3 errors generated.
make: *** [Python/random.o] Error 1

[ned-deily]

Pam, what version of macOS / OS X did this fail on?

[PamMcANulty]

Patch for fix

[PamMcANulty]

OSX: 10.11.6 (15G1212)
Xcode 8.2.1 Build version 8C1002

[ned-deily]

Argh! This is the third go-around on this problem, starting with the quick fix for macOS 10.12 in bpo-28676 then on to bpo-28932 where Benjamin added a more elaborate configure test when it broke OpenBSD, and now that causes builds on macOS versions earlier than 10.12 but newer than 10.4 or 10.5 to fail. (And, we haven't noticed it because, ATM, the only OS X buildbot active is a 10.4 one and the OpenBSD buildbot is down.) Benjamin, if you could have a look, please, if I don't get to it first.

[PamMcANulty]

I will say that, though my fix seems to work, it feels that the "right" place to put the fix is in ./configure.

Sadly, I don't speak './configure', though I apparently remember enough C from 17 years ago to get this working.

[benjaminp]

So, if sys/random.h can't be included without error why does the configure check for it work?

[PamMcANulty]

Good question.

It looks like there are 3 defines getting checked:
HAVE_SYS_RANDOM_H and either HAVE_GETRANDOM or HAVE_GETENTROPY

The previous issue seemed to be that you could have HAVE_GETRANDOM and/or HAVE_GETENTROPY be set, but still not have a sys/random.h, so a check was added for HAVE_SYS_RANDOM_H. However, on macs, you can HAVE_SYS_RANDOM_H, but still not have either HAVE_GETRANDOM or HAVE_GETENTROPY.

This _probably_ implies that the sys/random.h that's present isn't conformant enough for the compiler settings and my mac's os and/or xcode.

[PamMcANulty]

New patch to make consistent wrt use of "defined()"