Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_distutils fails on Android API level 24 #73371

Closed
xdegaye mannequin opened this issue Jan 6, 2017 · 5 comments
Closed

test_distutils fails on Android API level 24 #73371

xdegaye mannequin opened this issue Jan 6, 2017 · 5 comments
Labels
3.7 tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error

Comments

@xdegaye
Copy link
Mannequin

xdegaye mannequin commented Jan 6, 2017

BPO 29185
Nosy @merwok, @xdegaye, @dstufft
PRs
  • bpo-29185: Fix test_distutils failures on Android #4438
  • Files
  • test_distutils.patch
  • test_distutils_2.patch
  • test_distutils_3.patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2017-11-18.17:18:41.600>
    created_at = <Date 2017-01-06.21:18:27.705>
    labels = ['3.7', 'type-bug', 'tests']
    title = 'test_distutils fails on Android API level 24'
    updated_at = <Date 2017-11-18.17:18:41.599>
    user = 'https://github.com/xdegaye'

    bugs.python.org fields:

    activity = <Date 2017-11-18.17:18:41.599>
    actor = 'xdegaye'
    assignee = 'none'
    closed = True
    closed_date = <Date 2017-11-18.17:18:41.600>
    closer = 'xdegaye'
    components = ['Tests']
    creation = <Date 2017-01-06.21:18:27.705>
    creator = 'xdegaye'
    dependencies = []
    files = ['46195', '46269', '46271']
    hgrepos = []
    issue_num = 29185
    keywords = ['patch']
    message_count = 5.0
    messages = ['284850', '284921', '285315', '285324', '306486']
    nosy_count = 3.0
    nosy_names = ['eric.araujo', 'xdegaye', 'dstufft']
    pr_nums = ['4438']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue29185'
    versions = ['Python 3.7']

    @xdegaye
    Copy link
    Mannequin Author

    xdegaye mannequin commented Jan 6, 2017

    ======================================================================
    ERROR: test_tarfile_vs_tar (distutils.tests.test_archive_util.ArchiveUtilTestCase)
    ----------------------------------------------------------------------

    Traceback (most recent call last):
      File "/sdcard/org.bitbucket.pyona/lib/python3.7/distutils/tests/test_archive_util.py", line 170, i
    n test_tarfile_vs_tar
        spawn(gzip_cmd)
      File "/sdcard/org.bitbucket.pyona/lib/python3.7/distutils/spawn.py", line 36, in spawn
        _spawn_posix(cmd, search_path, dry_run=dry_run)
      File "/sdcard/org.bitbucket.pyona/lib/python3.7/distutils/spawn.py", line 159, in _spawn_posix
        % (cmd, exit_status))
    distutils.errors.DistutilsExecError: command 'gzip' failed with exit status 1

    ======================================================================
    FAIL: test_copy_file_hard_link (distutils.tests.test_file_util.FileUtilTestCase)
    ----------------------------------------------------------------------

    Traceback (most recent call last):
      File "/sdcard/org.bitbucket.pyona/lib/python3.7/distutils/tests/test_file_util.py", line 88, in te
    st_copy_file_hard_link
        self.assertTrue(os.path.samestat(st2, st3), (st2, st3))
    AssertionError: False is not true : (os.stat_result(st_mode=33206, st_ino=15948, st_dev=64800, st_nl
    ink=1, st_uid=2000, st_gid=2000, st_size=12, st_atime=1483691935, st_mtime=1483691935, st_ctime=1483
    691935), os.stat_result(st_mode=33206, st_ino=15949, st_dev=64800, st_nlink=1, st_uid=2000, st_gid=2
    000, st_size=12, st_atime=1483691935, st_mtime=1483691935, st_ctime=1483691935))

    Ran 236 tests in 1.885s

    FAILED (failures=1, errors=1, skipped=38)
    test test_distutils failed

    @xdegaye xdegaye mannequin self-assigned this Jan 6, 2017
    @xdegaye xdegaye mannequin added 3.7 tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error labels Jan 6, 2017
    @xdegaye
    Copy link
    Mannequin Author

    xdegaye mannequin commented Jan 7, 2017

    Patch attached.

    @xdegaye
    Copy link
    Mannequin Author

    xdegaye mannequin commented Jan 12, 2017

    This new patch skips the second test when hard links fail on the platform under test.

    @xdegaye
    Copy link
    Mannequin Author

    xdegaye mannequin commented Jan 12, 2017

    can_symlink() is needed by test_posixpath and other tests, new patch.

    @xdegaye xdegaye mannequin removed their assignment Feb 3, 2017
    @xdegaye
    Copy link
    Mannequin Author

    xdegaye mannequin commented Nov 18, 2017

    New changeset d34d8fc by xdegaye in branch 'master':
    bpo-29185: Fix test_distutils failures on Android (GH-4438)
    d34d8fc

    @xdegaye xdegaye mannequin closed this as completed Nov 18, 2017
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.7 tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Development

    No branches or pull requests

    0 participants