-
-
Notifications
You must be signed in to change notification settings - Fork 31.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support of new crypt methods #75845
Comments
Proposed PR adds support of three new methods in the crypt module.
mksalt() now takes the log_rounds argument for Blowfish. I'm not sure this is the best solution. And what should be a default value? |
-1 on DES and NT Hash These are very old, very bad algorithms and should no longer be used. We are in the 21th century. |
I concur. Initially I implemented all three methods, then removed they except Blowfish, and then re-added they back just for showing they to security experts. |
In bpo-31702 I propose related improvement for the SHA-* methods. |
Failure on s390x SLES 3.x: http://buildbot.python.org/all/#/builders/16/builds/65 ====================================================================== Traceback (most recent call last):
File "/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Lib/test/test_crypt.py", line 60, in test_invalid_log_rounds
self.assertIsNone(crypt.crypt('mypassword', salt))
AssertionError: '*0' is not None |
Tests on s390x SLES 3.x are passed. |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
bugs.python.org fields:
The text was updated successfully, but these errors were encountered: