os.statvfs lacks f_fsid

[giuseppe]

BPO	32143
Nosy	@freddrake, @vadmium, @giuseppe
PRs	bpo-32143: add f_fsid to os.statvfs() #4571

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2017-12-14.23:23:55.991>
created_at = <Date 2017-11-26.16:17:33.547>
labels = ['type-feature', 'library']
title = 'os.statvfs lacks f_fsid'
updated_at = <Date 2017-12-14.23:23:55.989>
user = 'https://github.com/giuseppe'

bugs.python.org fields:

activity = <Date 2017-12-14.23:23:55.989>
actor = 'fdrake'
assignee = 'none'
closed = True
closed_date = <Date 2017-12-14.23:23:55.991>
closer = 'fdrake'
components = ['Library (Lib)']
creation = <Date 2017-11-26.16:17:33.547>
creator = 'gscrivano'
dependencies = []
files = []
hgrepos = []
issue_num = 32143
keywords = ['patch']
message_count = 5.0
messages = ['307007', '307021', '308292', '308342', '308344']
nosy_count = 3.0
nosy_names = ['fdrake', 'martin.panter', 'gscrivano']
pr_nums = ['4571']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue32143'
versions = []

[giuseppe]

the os.statvfs() function doesn't return f_fsid. The POSIX definition of statvfs() has f_fsid:

http://pubs.opengroup.org/onlinepubs/009604599/basedefs/sys/statvfs.h.html

[vadmium]

The doc string for the result object, and the main Python 2 documentation, both say that the result is a 10-tuple. So perhaps any new field should only be an attribute, and the tuple should stay the same size, to maintain compatibility. This was done in other cases, e.g. struct_time and stat_result.

[freddrake]

I think Giuseppe's patch is good, but there's a Windows failure on AppVeyor, so I'm a little wary. It doesn't look related, but I haven't looked at Python on Windows since... 2001, maybe?

[freddrake]

New changeset 96a5e50 by Fred Drake (Giuseppe Scrivano) in branch 'master':
bpo-32143: add f_fsid to os.statvfs() (bpo-4571)
96a5e50

[freddrake]

This has landed on master and will be part of Python 3.7.