smtplib SMTP instances missing a default sock attribute

[romuald]

BPO	32680
Nosy	@giampaolo, @matrixise, @romuald
PRs	bpo-32680 add default "sock" on SMTP objects #5345

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2018-10-09.14:35:41.687>
created_at = <Date 2018-01-26.15:26:15.614>
labels = ['3.8']
title = 'smtplib SMTP instances missing a default sock attribute'
updated_at = <Date 2018-10-09.14:35:41.685>
user = 'https://github.com/romuald'

bugs.python.org fields:

activity = <Date 2018-10-09.14:35:41.685>
actor = 'giampaolo.rodola'
assignee = 'none'
closed = True
closed_date = <Date 2018-10-09.14:35:41.687>
closer = 'giampaolo.rodola'
components = []
creation = <Date 2018-01-26.15:26:15.614>
creator = 'Romuald'
dependencies = []
files = []
hgrepos = []
issue_num = 32680
keywords = ['patch']
message_count = 7.0
messages = ['310764', '310766', '310774', '311553', '311554', '327409', '327410']
nosy_count = 4.0
nosy_names = ['giampaolo.rodola', 'matrixise', 'Romuald', 'amirjn']
pr_nums = ['5345']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue32680'
versions = ['Python 3.8']

[romuald]

SMTP instances from the smtplib module are not creating their sock attribute consistently after __init__

When host is sent as parameter a sock object is created (and hopefully, connected)

When the host is not sent, the sock attribute doesn't exist at all

[romuald]

My use case:

try:
s = SMTP('myhost')
s.do_some_sending()
finaly:
if s is not None and s.sock is not None:
s.quit()

But I realize just now that in that case, if s was initialized correctly, its sock was inevitably set

[matrixise]

You are right, but...

if there is an exception in the connect method before the init of
self.sock, the sock attribute will not exist and in this case, and only
in this case, there will be an exception in the close method.

your code will work fine if you use a try/finally but not in the case
where we use the with statement, for example.

with SMTP('myhost') as smtp:
   smtp.do_something()

If there is an exception in the __init__ of SMTP and self.sock is not
initialized -> traceback.

[amirjn]

same problem at apple.com

[amirjn]

<a href="apple.com">apple.com</a>

[giampaolo]

New changeset 7b31397 by Giampaolo Rodola (Romuald Brunet) in branch 'master':
bpo-32680 add default "sock" on SMTP objects (bpo-5345)
7b31397

[giampaolo]

PR merged for 3.8 branch. I don't think such a simple change deserves a backport for previous Python versions. Closing this out as resolved.