NoReturn missing from __all__ in typing.py

[aetracht]

BPO	33061
Nosy	@gvanrossum, @ilevkivskyi, @aetracht
PRs	bpo-33061: Add missing 'NoReturn' to __all__ in typing.py #6127 [3.7] bpo-33061: Add missing 'NoReturn' to __all__ in typing.py (GH-6127) #6162

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2018-03-23.21:47:40.612>
created_at = <Date 2018-03-12.22:15:08.483>
labels = ['3.7', '3.8', 'type-bug', 'library']
title = 'NoReturn missing from __all__ in typing.py'
updated_at = <Date 2018-03-23.21:47:40.611>
user = 'https://github.com/aetracht'

bugs.python.org fields:

activity = <Date 2018-03-23.21:47:40.611>
actor = 'levkivskyi'
assignee = 'none'
closed = True
closed_date = <Date 2018-03-23.21:47:40.612>
closer = 'levkivskyi'
components = ['Library (Lib)']
creation = <Date 2018-03-12.22:15:08.483>
creator = 'AllenTracht'
dependencies = []
files = []
hgrepos = []
issue_num = 33061
keywords = ['patch']
message_count = 6.0
messages = ['313962', '313963', '314111', '314170', '314335', '314336']
nosy_count = 3.0
nosy_names = ['gvanrossum', 'levkivskyi', 'AllenTracht']
pr_nums = ['6127', '6162']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue33061'
versions = ['Python 3.4', 'Python 3.5', 'Python 3.6', 'Python 3.7', 'Python 3.8']

[ilevkivskyi]

This is clearly a bug. Would you like to make a PR?

[gvanrossum]

Yes please! Updating __all__ is too easy to forget.

IIRC there are scripts that check for this but they are too strict.

[ilevkivskyi]

New changeset 4573820 by Ivan Levkivskyi (aetracht) in branch 'master':
bpo-33061: Add missing 'NoReturn' to __all__ in typing.py (GH-6127)
4573820

[ilevkivskyi]

I think it makes sense to also fix this in 3.7. I will prepare a backport now.

[ilevkivskyi]

New changeset ac56027 by Ivan Levkivskyi in branch '3.7':
bpo-33061: Add missing 'NoReturn' to __all__ in typing.py (GH-6127) (bpo-6162)
ac56027

[ilevkivskyi]

The typing repo PR is not merged yet, but I am closing this here, the remainder is tracked in typing repo.