Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PySys_Audit should require PY_SSIZE_T_CLEAN #83189

Closed
zooba opened this issue Dec 9, 2019 · 3 comments
Closed

PySys_Audit should require PY_SSIZE_T_CLEAN #83189

zooba opened this issue Dec 9, 2019 · 3 comments
Assignees
Labels
3.8 only security fixes 3.9 only security fixes type-bug An unexpected behavior, bug, or error

Comments

@zooba
Copy link
Member

zooba commented Dec 9, 2019

BPO 39008
Nosy @zooba, @miss-islington
PRs
  • bpo-39008: Require Py_ssize_t for PySys_Audit formats rather than raise a deprecation warning #17540
  • [3.8] bpo-39008: Require Py_ssize_t for PySys_Audit formats rather than raise a deprecation warning (GH-17540) #17542
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/zooba'
    closed_at = <Date 2019-12-09.19:10:57.638>
    created_at = <Date 2019-12-09.18:34:13.105>
    labels = ['type-bug', '3.8', '3.9']
    title = 'PySys_Audit should require PY_SSIZE_T_CLEAN'
    updated_at = <Date 2019-12-09.19:22:36.979>
    user = 'https://github.com/zooba'

    bugs.python.org fields:

    activity = <Date 2019-12-09.19:22:36.979>
    actor = 'miss-islington'
    assignee = 'steve.dower'
    closed = True
    closed_date = <Date 2019-12-09.19:10:57.638>
    closer = 'steve.dower'
    components = []
    creation = <Date 2019-12-09.18:34:13.105>
    creator = 'steve.dower'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 39008
    keywords = ['patch']
    message_count = 3.0
    messages = ['358125', '358130', '358132']
    nosy_count = 2.0
    nosy_names = ['steve.dower', 'miss-islington']
    pr_nums = ['17540', '17542']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue39008'
    versions = ['Python 3.8', 'Python 3.9']

    @zooba
    Copy link
    Member Author

    zooba commented Dec 9, 2019

    Currently, calls to PySys_Audit() that use "#" format strings will raise a deprecation warning because Python/sysmodule.c is not PY_SSIZE_T_CLEAN

    Since PySys_Audit is a new API, we should just define it as always requiring Py_ssize_t.

    (Discovered while implementing bpo-39007).

    @zooba zooba self-assigned this Dec 9, 2019
    @zooba zooba added the type-bug An unexpected behavior, bug, or error label Dec 9, 2019
    @zooba zooba self-assigned this Dec 9, 2019
    @zooba zooba added the type-bug An unexpected behavior, bug, or error label Dec 9, 2019
    @zooba
    Copy link
    Member Author

    zooba commented Dec 9, 2019

    New changeset b8cbe74 by Steve Dower in branch 'master':
    bpo-39008: Require Py_ssize_t for PySys_Audit formats rather than raise a deprecation warning (GH-17540)
    b8cbe74

    @zooba zooba added 3.8 only security fixes 3.9 only security fixes labels Dec 9, 2019
    @zooba zooba closed this as completed Dec 9, 2019
    @zooba zooba added 3.8 only security fixes 3.9 only security fixes labels Dec 9, 2019
    @zooba zooba closed this as completed Dec 9, 2019
    @miss-islington
    Copy link
    Contributor

    New changeset c93d68b by Miss Islington (bot) in branch '3.8':
    bpo-39008: Require Py_ssize_t for PySys_Audit formats rather than raise a deprecation warning (GH-17540)
    c93d68b

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.8 only security fixes 3.9 only security fixes type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants