NameError: name 'open' is not defined

[Sandeep]

BPO	39513
Nosy	@vsajip, @vstinner, @serhiy-storchaka, @tirkarthi
Superseder	bpo-26789: logging: Trying to log during Python finalization with NameError: name 'open' is not defined

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2020-10-30.14:23:33.363>
created_at = <Date 2020-01-31.19:15:26.321>
labels = ['library', 'type-crash']
title = "NameError: name 'open' is not defined"
updated_at = <Date 2020-10-30.16:59:21.407>
user = 'https://bugs.python.org/Sandeep'

bugs.python.org fields:

activity = <Date 2020-10-30.16:59:21.407>
actor = 'vstinner'
assignee = 'none'
closed = True
closed_date = <Date 2020-10-30.14:23:33.363>
closer = 'vstinner'
components = ['Library (Lib)']
creation = <Date 2020-01-31.19:15:26.321>
creator = 'Sandeep'
dependencies = []
files = []
hgrepos = []
issue_num = 39513
keywords = []
message_count = 9.0
messages = ['361125', '361127', '361219', '361222', '361224', '379951', '379965', '379983', '379985']
nosy_count = 5.0
nosy_names = ['vinay.sajip', 'vstinner', 'serhiy.storchaka', 'xtreak', 'Sandeep']
pr_nums = []
priority = 'normal'
resolution = 'duplicate'
stage = 'resolved'
status = 'closed'
superseder = '26789'
type = 'crash'
url = 'https://bugs.python.org/issue39513'
versions = ['Python 3.6']

[Sandeep]

Hi
I wrote a python script which gets file from other server and it works fine till the time I don't introduces logging feature to it.
Please advice how to fix below

This is the code I am using for logging '

import logging
logging.basicConfig(filename=localLogfile, level=logging.DEBUG)

--Error Message

Traceback (most recent call last):
  File "/d01/python3/lib64/python3.6/site-packages/pysftp/__init__.py", line 1013, in __del__
  File "/d01/python3/lib64/python3.6/site-packages/pysftp/__init__.py", line 785, in close
  File "/d01/python3/lib64/python3.6/site-packages/paramiko/sftp_client.py", line 194, in close
  File "/d01/python3/lib64/python3.6/site-packages/paramiko/sftp_client.py", line 185, in _log
  File "/d01/python3/lib64/python3.6/site-packages/paramiko/sftp.py", line 158, in _log
  File "/opt/rh/rh-python36/root/usr/lib64/python3.6/logging/__init__.py", line 1372, in log
  File "/opt/rh/rh-python36/root/usr/lib64/python3.6/logging/__init__.py", line 1442, in _log
  File "/opt/rh/rh-python36/root/usr/lib64/python3.6/logging/__init__.py", line 1452, in handle
  File "/opt/rh/rh-python36/root/usr/lib64/python3.6/logging/__init__.py", line 1514, in callHandlers
  File "/opt/rh/rh-python36/root/usr/lib64/python3.6/logging/__init__.py", line 863, in handle
  File "/opt/rh/rh-python36/root/usr/lib64/python3.6/logging/__init__.py", line 1069, in emit
  File "/opt/rh/rh-python36/root/usr/lib64/python3.6/logging/__init__.py", line 1059, in _open
NameError: name 'open' is not defined

[tirkarthi]

See also https://bugs.python.org/issue26789

[vsajip]

Please attach a small script which allows reproduction of this issue - otherwise, it's unlikely we'll be able to make much progress, and I'll probably close it in a week or so if you haven't been able to do this. Thanks!

[serhiy-storchaka]

Symptoms as when try to log very late at shutdown stage, when the content of the builtin module is restored to its original value which does not include open imported from io.

[vsajip]

Well, my comment/request was prompted by whether this issue is a duplicate of bpo-26789, because it's not clear from the OP. If it is, then it can be closed as such. I don't think this is specifically a logging problem, more a case of how things become inaccessible as the interpreter shuts down. Any code which calls "open" (or some other builtins) would run into this problem, not just and not specifically logging. I'm not sure, but I don't believe we have a good answer to this problem in general.

[serhiy-storchaka]

I think this is a multi-level problem, and it perhaps should be solved on different levels separately.

As for logging, it can be used at shutdown by user code, it may help to understand the problem with the user code, and it may work most of time. But if it happen too late, it fails, and the printed traceback does not help but confuses user. The logging module should try the best to help the user. It should be ready to handle such situation. It is not failure of the end user that this error happens, and they cannot do anything in any way, so it is better to suppress the confusion traceback (maybe emit a warning?).

[vstinner]

I mark this issue as a duplicate of bpo-26789.

[serhiy-storchaka]

bpo-26789 is about asyncio, but this issue about logging.

[vstinner]

bpo-26789 is about asyncio, but this issue about logging.

I chose to reassign bpo-26789 to the logging module.