venv activate scripts do not pass ShellCheck

[donpellegrino]

BPO	41516
Nosy	@terryjreedy, @vsajip, @donpellegrino

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = None
created_at = <Date 2020-08-10.15:52:50.472>
labels = ['extension-modules', 'type-feature', '3.10']
title = 'venv activate scripts do not pass ShellCheck'
updated_at = <Date 2020-08-14.20:09:18.113>
user = 'https://github.com/donpellegrino'

bugs.python.org fields:

activity = <Date 2020-08-14.20:09:18.113>
actor = 'terry.reedy'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Extension Modules']
creation = <Date 2020-08-10.15:52:50.472>
creator = 'user93448'
dependencies = []
files = []
hgrepos = []
issue_num = 41516
keywords = []
message_count = 2.0
messages = ['375125', '375430']
nosy_count = 3.0
nosy_names = ['terry.reedy', 'vinay.sajip', 'user93448']
pr_nums = []
priority = 'normal'
resolution = None
stage = None
status = 'open'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue41516'
versions = ['Python 3.10']

[donpellegrino]

The activate scripts created by the venv module do not pass checks by ShellCheck (https://www.shellcheck.net/). ShellCheck generally has a point for each warning and note generated against the venv activate scripts. Addressing the ShellCheck reports would align the activate script implementation with best practices.

[terryjreedy]

(3.6 only gets security fixes.) Please be more specific: venv produces 6 types of scripts. Which type(s) are seen as buggy? Can you paste a script produced by venv and its ShellCheck output? (The web site has a paste-in box.) Have you used ShellCheck? Can you sign the contributor agreement submit a PR? (Yes, we do sometimes create, review, and upon agreement merge patches based of various code and text checkers.)