New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade macOS and Windows installers to use SQLite 3.34.0 #86750
Comments
SQLite 3.34.0 was released 2020-12-01: https://www.sqlite.org/releaselog/3_34_0.html Compiles fine on master, and tests are completing without error. |
Steve Dower: It should be fairly easy to add a CI check that validates the source checksums, so you don't need to do it manually every time. I can throw up a simple GH workflow for the sqlite branch if you want. |
See attached proof-of-concept CI check. This GitHub Workflow extracts the SQLite version information, downloads the amalgamation source code, and does a simple Example run: https://github.com/erlend-aasland/cpython-source-deps/runs/1586069119?check_suite_focus=true |
Honestly, keeping a CI run alive is more work than just doing the extract and push myself. I know this means it feels like you can't do as much yourself to speed up the integration, but it really isn't going to slow it down that much. FWIW, any core dev can merge SQLite updates for Windows (if they're satisfied there are no issues). It's only OpenSSL that relies on running a signed build. |
A CI check would indicate that there are no issues. The PoC CI is just a short bash script wrapped in GitHub's workflow syntax. I'd be happy to maintain it, FWIW. On the other hand, adding a CI check is not super important for me :) https://sqlite.org/versionnumbers.html: |
Ned Deily, can you fix the macOS backports? |
Steve Dower, do you mind if I create backports for the Windows build as well? |
Sorry, I've been doing it. They're just slow because I'm getting OpenSSL done at the same time and they both keep causing merge conflicts. |
No problem. I noticed that, so I aborted my cherry-picker. |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
bugs.python.org fields:
The text was updated successfully, but these errors were encountered: