Upgrade macOS and Windows installers to use SQLite 3.34.0

[erlend-aasland]

BPO	42584
Nosy	@ned-deily, @zooba, @miss-islington, @erlend-aasland
PRs	bpo-42584: Update macOS installer to use SQLite 3.34.0 #23674 bpo-42584 : Update Windows installer to use SQLite 3.34.0 #23675 [3.8] bpo-42584: Update macOS installer to use SQLite 3.34.0 (GH-23674). #24129 [3.9] bpo-42584: Update macOS installer to use SQLite 3.34.0 (GH-23674) #24130 [3.9] bpo-42584: Update Windows installer to use SQLite 3.34.0 (GH-23675) #24132 [3.8] bpo-42584: Update Windows installer to use SQLite 3.34.0 (GH-23675) #24133
Files	0001-Add-simple-validation-CI.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2021-01-06.00:31:40.379>
created_at = <Date 2020-12-07.10:36:22.525>
labels = ['3.8', 'library', '3.9', '3.10']
title = 'Upgrade macOS and Windows installers to use SQLite 3.34.0'
updated_at = <Date 2021-01-06.00:31:40.379>
user = 'https://github.com/erlend-aasland'

bugs.python.org fields:

activity = <Date 2021-01-06.00:31:40.379>
actor = 'steve.dower'
assignee = 'none'
closed = True
closed_date = <Date 2021-01-06.00:31:40.379>
closer = 'steve.dower'
components = ['Library (Lib)']
creation = <Date 2020-12-07.10:36:22.525>
creator = 'erlendaasland'
dependencies = []
files = ['49718']
hgrepos = []
issue_num = 42584
keywords = ['patch']
message_count = 15.0
messages = ['382625', '382628', '383468', '384307', '384329', '384351', '384435', '384437', '384438', '384439', '384440', '384447', '384449', '384450', '384456']
nosy_count = 4.0
nosy_names = ['ned.deily', 'steve.dower', 'miss-islington', 'erlendaasland']
pr_nums = ['23674', '23675', '24129', '24130', '24132', '24133']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue42584'
versions = ['Python 3.8', 'Python 3.9', 'Python 3.10']

[erlend-aasland]

SQLite 3.34.0 was released 2020-12-01: https://www.sqlite.org/releaselog/3_34_0.html

Compiles fine on master, and tests are completing without error.

[erlend-aasland]

Steve Dower: It should be fairly easy to add a CI check that validates the source checksums, so you don't need to do it manually every time. I can throw up a simple GH workflow for the sqlite branch if you want.

[erlend-aasland]

See attached proof-of-concept CI check. This GitHub Workflow extracts the SQLite version information, downloads the amalgamation source code, and does a simple cmp on each file.

Example run: https://github.com/erlend-aasland/cpython-source-deps/runs/1586069119?check_suite_focus=true

[ned-deily]

New changeset c94ee13 by Erlend Egeberg Aasland in branch 'master':
bpo-42584: Update macOS installer to use SQLite 3.34.0 (GH-23674)
c94ee13

[zooba]

Honestly, keeping a CI run alive is more work than just doing the extract and push myself. I know this means it feels like you can't do as much yourself to speed up the integration, but it really isn't going to slow it down that much.

FWIW, any core dev can merge SQLite updates for Windows (if they're satisfied there are no issues). It's only OpenSSL that relies on running a signed build.

[erlend-aasland]

FWIW, any core dev can merge SQLite updates for Windows (if they're satisfied there are no issues).

A CI check would indicate that there are no issues. The PoC CI is just a short bash script wrapped in GitHub's workflow syntax. I'd be happy to maintain it, FWIW. On the other hand, adding a CI check is not super important for me :)

https://sqlite.org/versionnumbers.html:
"[…] the current tarball naming conventions only reserve two digits for the Y and so the naming format for downloads will need to be revised in about 2030."

[zooba]

New changeset dd74c01 by Erlend Egeberg Aasland in branch 'master':
bpo-42584: Update Windows installer to use SQLite 3.34.0 (GH-23675)
dd74c01

[erlend-aasland]

Ned Deily, can you fix the macOS backports?

[erlend-aasland]

Steve Dower, do you mind if I create backports for the Windows build as well?

[miss-islington]

New changeset f27451d by Erlend Egeberg Aasland in branch '3.8':
[3.8] bpo-42584: Update macOS installer to use SQLite 3.34.0 (GH-23674). (GH-24129)
f27451d

[miss-islington]

New changeset e9a71da by Erlend Egeberg Aasland in branch '3.9':
[3.9] bpo-42584: Update macOS installer to use SQLite 3.34.0 (GH-23674) (GH-24130)
e9a71da

[zooba]

Steve Dower, do you mind if I create backports for the Windows build as well?

Sorry, I've been doing it. They're just slow because I'm getting OpenSSL done at the same time and they both keep causing merge conflicts.

[zooba]

New changeset 77d5471 by Steve Dower in branch '3.9':
bpo-42584: Update Windows installer to use SQLite 3.34.0 (GH-23675)
77d5471

[erlend-aasland]

Sorry, I've been doing it. They're just slow because I'm getting OpenSSL done at the same time and they both keep causing merge conflicts.

No problem. I noticed that, so I aborted my cherry-picker.

[zooba]

New changeset db91714 by Steve Dower in branch '3.8':
bpo-42584: Update Windows installer to use SQLite 3.34.0 (GH-23675)
db91714