Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenSSL 3.0.0: handle empty cadata consistently #88086

Closed
tiran opened this issue Apr 23, 2021 · 4 comments
Closed

OpenSSL 3.0.0: handle empty cadata consistently #88086

tiran opened this issue Apr 23, 2021 · 4 comments
Assignees
Labels
3.8 3.9 3.10 3.11 expert-SSL type-bug

Comments

@tiran
Copy link
Member

@tiran tiran commented Apr 23, 2021

BPO 43920
Nosy @tiran
PRs
  • #25554
  • #25555
  • #25556
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/tiran'
    closed_at = <Date 2021-04-23.14:37:43.140>
    created_at = <Date 2021-04-23.09:52:47.430>
    labels = ['expert-SSL', 'type-bug', '3.8', '3.9', '3.10', '3.11']
    title = 'OpenSSL 3.0.0: handle empty cadata consistently'
    updated_at = <Date 2021-04-23.14:37:43.140>
    user = 'https://github.com/tiran'

    bugs.python.org fields:

    activity = <Date 2021-04-23.14:37:43.140>
    actor = 'christian.heimes'
    assignee = 'christian.heimes'
    closed = True
    closed_date = <Date 2021-04-23.14:37:43.140>
    closer = 'christian.heimes'
    components = ['SSL']
    creation = <Date 2021-04-23.09:52:47.430>
    creator = 'christian.heimes'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 43920
    keywords = ['patch']
    message_count = 4.0
    messages = ['391673', '391682', '391689', '391699']
    nosy_count = 1.0
    nosy_names = ['christian.heimes']
    pr_nums = ['25554', '25555', '25556']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue43920'
    versions = ['Python 3.8', 'Python 3.9', 'Python 3.10', 'Python 3.11']

    @tiran
    Copy link
    Member Author

    @tiran tiran commented Apr 23, 2021

    OpenSSL 3.0.0-alpha15 handles empty data input to d2i_X509_bio() and PEM_read_bio_X509() differently. This causes cadata test for invalid data to fail with inconsistent error message.

    Let's handle 0 result case more consistent and raise an error message that is more understandable than "no start line" or "not enough data".

    @tiran tiran self-assigned this Apr 23, 2021
    @tiran tiran added expert-SSL type-bug 3.8 3.9 3.10 3.11 labels Apr 23, 2021
    @tiran tiran self-assigned this Apr 23, 2021
    @tiran tiran added expert-SSL type-bug labels Apr 23, 2021
    @tiran
    Copy link
    Member Author

    @tiran tiran commented Apr 23, 2021

    New changeset b9ad88b by Christian Heimes in branch 'master':
    bpo-43920: Make load_verify_locations(cadata) error message consistent (GH-25554)
    b9ad88b

    @tiran
    Copy link
    Member Author

    @tiran tiran commented Apr 23, 2021

    New changeset e259a77 by Christian Heimes in branch '3.9':
    [3.9] bpo-43920: Make load_verify_locations(cadata) error message consistent (GH-25554) (GH-25555)
    e259a77

    @tiran
    Copy link
    Member Author

    @tiran tiran commented Apr 23, 2021

    New changeset 82b6c09 by Christian Heimes in branch '3.8':
    [3.8] bpo-43920: Make load_verify_locations(cadata) error message consistent (GH-25554) (GH-25556)
    82b6c09

    @tiran tiran closed this as completed Apr 23, 2021
    @tiran tiran closed this as completed Apr 23, 2021
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.8 3.9 3.10 3.11 expert-SSL type-bug
    Projects
    None yet
    Development

    No branches or pull requests

    1 participant