You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
assignee='https://github.com/tiran'closed_at=<Date2021-10-22.13:37:02.817>created_at=<Date2021-04-29.09:02:26.399>labels= ['extension-modules', 'type-bug', 'build', '3.11']
title='Define Py_BUILD_CORE_MODULE in extensions instead of setup.py and Modules/Setup'updated_at=<Date2022-02-21.11:46:32.070>user='https://github.com/tiran'
It looks like we can also cleanup Modules/Setup and remove -DPy_BUILD_CORE_BUILTIN and -DPy_BUILD_CORE_MODULE. Modules/makesetup adds $PY_BUILTIN_MODULE_CFLAGS in the compile step. The variable is defined as
The proposal is related to Brett's ticket bpo-45548. I no longer think that we should define Py_BUILD_CORE_MODULE unconditionally. Instead I propose to move the defines into each C module. This avoids duplication of macros in setup.py and Modules/Setup.