Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the removal the usage of the C stack in Python to Python calls #89480

Open
markshannon opened this issue Sep 29, 2021 · 7 comments
Open
Assignees
Labels
3.11 bug and security fixes deferred-blocker docs Documentation in the Doc dir type-feature A feature request or enhancement

Comments

@markshannon
Copy link
Member

BPO 45317
Nosy @markshannon, @pablogsal
PRs
  • GH-89480: Document motivation, design and implementation of 3.11 frame stack. #32304
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/pablogsal'
    closed_at = None
    created_at = <Date 2021-09-29.11:40:33.214>
    labels = ['3.11', 'type-feature', 'deferred-blocker', 'docs']
    title = 'Document the removal the usage of the C stack in Python to Python calls'
    updated_at = <Date 2022-04-04.14:10:02.227>
    user = 'https://github.com/markshannon'

    bugs.python.org fields:

    activity = <Date 2022-04-04.14:10:02.227>
    actor = 'Mark.Shannon'
    assignee = 'pablogsal'
    closed = False
    closed_date = None
    closer = None
    components = ['Documentation']
    creation = <Date 2021-09-29.11:40:33.214>
    creator = 'Mark.Shannon'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 45317
    keywords = ['patch']
    message_count = 3.0
    messages = ['402850', '402853', '414655']
    nosy_count = 3.0
    nosy_names = ['docs@python', 'Mark.Shannon', 'pablogsal']
    pr_nums = ['32304']
    priority = 'deferred blocker'
    resolution = None
    stage = 'patch review'
    status = 'open'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue45317'
    versions = ['Python 3.11']

    @markshannon
    Copy link
    Member Author

    Assuming that bpo-45256 is implemented, we will need to document it.

    I'm opening a separate issue, so this doesn't get lost in the midst of 45256.

    We need to:

    Document the changes to gdb. Possibly at https://wiki.python.org/moin/DebuggingWithGdb, or in the main docs.

    Add a "what's new" entry explaining what the impact of this change is.

    @markshannon markshannon added release-blocker 3.11 bug and security fixes docs Documentation in the Doc dir type-feature A feature request or enhancement labels Sep 29, 2021
    @markshannon markshannon added release-blocker 3.11 bug and security fixes docs Documentation in the Doc dir type-feature A feature request or enhancement labels Sep 29, 2021
    @pablogsal
    Copy link
    Member

    I will prepare a PR to also document the gdb helpers in the main docs. The wiki is insuficient.

    @pablogsal pablogsal assigned pablogsal and unassigned markshannon Sep 29, 2021
    @markshannon
    Copy link
    Member Author

    I don't think this needs to block the alpha release

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    @vstinner
    Copy link
    Member

    vstinner commented May 6, 2022

    What's New in Python 3.11 now says:

    Most Python function calls now consume no C stack space.

    https://docs.python.org/dev/whatsnew/3.11.html#inlined-python-function-calls

    Can this issue be claused?

    @pablogsal:

    I will prepare a PR to also document the gdb helpers in the main docs. The wiki is insuficient.

    It seems like this part was not done yet.

    By the way, having a documentation about debugging Python in gdb would be great. I can help writing it if you want!

    @pablogsal
    Copy link
    Member

    ⚠️ This issue has been updated from 'deferred-blocker' to 'release blocker' as we are past beta1. This issue will block the next release (Python 3.11.0 beta 2). ⚠️

    @pablogsal
    Copy link
    Member

    It seems like this part was not done yet.

    By the way, having a documentation about debugging Python in gdb would be great. I can help writing it if you want!

    I have something prepared but I still need time to do a PR :)

    @JelleZijlstra
    Copy link
    Member

    This is still marked a deferred blocker. @pablogsal are you planning on writing new GDB docs, and should those docs block any release?

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.11 bug and security fixes deferred-blocker docs Documentation in the Doc dir type-feature A feature request or enhancement
    Projects
    Status: No status
    Development

    No branches or pull requests

    4 participants