[Windows] OSError should unconditionally call winerror_to_errno

[eryksun]

BPO	46775
Nosy	@pfmoore, @tjguk, @zware, @eryksun, @zooba, @corona10, @miss-islington
PRs	bpo-46775: OSError should call winerror_to_errno unconditionally #32179 [3.10] bpo-46775: OSError should call winerror_to_errno unconditionally on Windows (GH-32179) #32198 [3.9] bpo-46775: OSError should call winerror_to_errno unconditionally on Windows (GH-32179) #32199

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2022-03-31.02:51:30.988>
created_at = <Date 2022-02-17.03:54:21.496>
labels = ['interpreter-core', 'easy', 'type-bug', '3.9', '3.10', '3.11', 'OS-windows']
title = '[Windows] OSError should unconditionally call winerror_to_errno'
updated_at = <Date 2022-03-31.02:51:30.987>
user = 'https://github.com/eryksun'

bugs.python.org fields:

activity = <Date 2022-03-31.02:51:30.987>
actor = 'corona10'
assignee = 'none'
closed = True
closed_date = <Date 2022-03-31.02:51:30.988>
closer = 'corona10'
components = ['Interpreter Core', 'Windows']
creation = <Date 2022-02-17.03:54:21.496>
creator = 'eryksun'
dependencies = []
files = []
hgrepos = []
issue_num = 46775
keywords = ['patch', 'easy (C)']
message_count = 6.0
messages = ['413383', '416282', '416387', '416393', '416411', '416412']
nosy_count = 7.0
nosy_names = ['paul.moore', 'tim.golden', 'zach.ware', 'eryksun', 'steve.dower', 'corona10', 'miss-islington']
pr_nums = ['32179', '32198', '32199']
priority = 'normal'
resolution = None
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue46775'
versions = ['Python 3.9', 'Python 3.10', 'Python 3.11']

[eryksun]

bpo-37705 overlooked fixing the OSError constructor. oserror_parse_args() in Objects/exceptions.c should unconditionally call winerror_to_errno(), which is defined in PC/errmap.h.

winerror_to_errno() maps the Winsock range 10000-11999 directly, except for the 6 errors in this range that are based on C errno values: WSAEINTR, WSAEBADF, WSAEACCES, WSAEFAULT, WSAEINVAL, and WSAEMFILE. Otherwise, Windows error codes that aren't mapped explicitly get mapped by default to EINVAL.

[zooba]

Is this okay to backport? Correcting more winerror values means we'll get more subclasses raised instead of OSError (though only for obscure cases, which probably also aren't mapped, so I guess it's possible to prove that none will actually change right now).

[zooba]

New changeset d0c67ea by Dong-hee Na in branch 'main':
bpo-46775: OSError should call winerror_to_errno unconditionally on Windows (GH-32179)
d0c67ea

[zooba]

I'm still not convinced we should backport. Has anyone looked through to see whether this will actually affect any high valued error codes today?

[miss-islington]

New changeset 1f2ec4c by Miss Islington (bot) in branch '3.10':
bpo-46775: OSError should call winerror_to_errno unconditionally on Windows (GH-32179)
1f2ec4c

[miss-islington]

New changeset d04a213 by Miss Islington (bot) in branch '3.9':
bpo-46775: OSError should call winerror_to_errno unconditionally on Windows (GH-32179)
d04a213