-
-
Notifications
You must be signed in to change notification settings - Fork 33.1k
Labels
3.12only security fixesonly security fixesextension-modulesC modules in the Modules dirC modules in the Modules dirtype-featureA feature request or enhancementA feature request or enhancement
Description
The bz2 and overlapped extension modules both have unneeded module state. That is, their state only contains pointers to types that are only added to the module's dict, and not used anywhere else. This implies:
- there is no need to allocate and deallocate module state
- there is no need to implement the traverse/clear/free module methods
- there is no need for a state struct, and related "get state" helpers
For each module, this amounts to approx. 50 fewer lines of code. Less code, less maintenance.
For extension modules with partial unneeded module state, it may be best to leave them as they are; consistency also has a value.
Metadata
Metadata
Assignees
Labels
3.12only security fixesonly security fixesextension-modulesC modules in the Modules dirC modules in the Modules dirtype-featureA feature request or enhancementA feature request or enhancement