Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken links on documentation download pages #95290

Closed
hop opened this issue Jul 26, 2022 · 15 comments
Closed

Broken links on documentation download pages #95290

hop opened this issue Jul 26, 2022 · 15 comments
Labels
docs Documentation in the Doc dir

Comments

@hop
Copy link

hop commented Jul 26, 2022

I'm sorry, if there is a dedicated bug tracker for docs.python.org, I haven't been able to find it.

All links on https://docs.python.org/release/3.10.4/download.html (for all python versions) lead to a 404 page.

The links on that page are of the form:

https://docs.python.org/ftp/python/doc/3.10.4/python-3.10.4-docs-html.zip

which returns a 404 error.

The URL

https://docs.python.org/ftp/python/doc/3.10.4/

redirects to

https://www.python.org/ftp/python/doc/3.10.4/

(notice www. vs. docs.!) where all archives are present and downloadable.

I've verified this with curl on the command line. It is not a browswer issue.

@Mariatta
Copy link
Member

This could be due to the docs are still being built, and not yet available for download. As the error message suggests, can you try again in a couple more hours?

@Mariatta Mariatta transferred this issue from python/pythondotorg Jul 26, 2022
@AlexWaygood AlexWaygood added the docs Documentation in the Doc dir label Jul 26, 2022
@hop
Copy link
Author

hop commented Jul 26, 2022

As I wrote in my initial description: the docs are available for download

@hugovk
Copy link
Member

hugovk commented Jul 26, 2022

The bottom of the pages says "Last updated on Mar 23, 2022" so these are old docs.

https://docs.python.org/release/3.10.5/download.html is the latest 3.10, "Last updated on Jun 06, 2022", and has the same problem, so looks like a valid bug.

@hop
Copy link
Author

hop commented Jul 26, 2022

As I said in my initial description: the download pages for all python versions have the same problem.

@hugovk
Copy link
Member

hugovk commented Jul 26, 2022

@arhadthedev
Copy link
Member

arhadthedev commented Jul 26, 2022

@ned-deily Probably, #93853 (comment) should be reconsidered redesigned to not confuse doc readers.

@ned-deily
Copy link
Member

There is something wrong in a website redirect because those downloads are on the dl server for those releases. I don't have time to look into that at the moment. There should be a redirect from, for example, https://docs.python.org/ftp/python/doc/3.10.5/python-3.10.5-docs-pdf-letter.zip to https://www.python.org/ftp/python/doc/3.10.5/python-3.10.5-docs-pdf-letter.zip that is not happening. Perhaps someone else can look into that.

@hop
Copy link
Author

hop commented Jul 26, 2022

As I said, the redirect is there for the directory, but not for the archive files themselves.

It's now been several hours and the problem persists, so even if this has to do with the build process as @Mariatta suggested, it looks like problem to me.

@encukou
Copy link
Member

encukou commented Mar 23, 2023

@ewdurbin, can you set up redirects from https://docs.python.org/ftp to https://www.python.org/ftp?
As discussed above it would fix the docs download links, without needing to rebuild docs. IMO it's also better in long-term than changing build scripts, even though it'll be one more thing to think about if docs move to e.g. Read The Docs.

@ewdurbin
Copy link
Member

Yeah, that is doable right now in our cdn configuration. Though it should also be doable here: https://github.com/python/psf-salt/blob/main/salt/docs/config/nginx.docs-backend.conf

@ewdurbin
Copy link
Member

@ewdurbin
Copy link
Member

Oh, I see. That redirect should just need updated to match on the prefix /ftp. If anyone would like to open a PR to psf-salt I will happily review, merge, and deploy it.

@ewdurbin
Copy link
Member

Best guess is there is a bad interaction with the block directly above the ftp redirect given the following:

$ curl -s -I https://docs.python.org/ftp/python/doc/3.10.4/python-3.10.4-docs-html.zip
HTTP/2 404 
server: nginx
content-type: text/html

$ curl -s -I https://docs.python.org/ftp/python/doc/3.10.4/python-3.10.4-docs-html.zap
HTTP/2 301 
server: nginx
content-type: text/html
location: https://www.python.org/ftp/python/doc/3.10.4/python-3.10.4-docs-html.zap

@ewdurbin
Copy link
Member

looks resolved:

$ curl -s -I https://docs.python.org/ftp/python/doc/3.10.4/python-3.10.4-docs-html.zip
HTTP/2 404 
server: nginx
content-type: text/html
$ curl -XPURGE https://docs.python.org/ftp/python/doc/3.10.4/python-3.10.4-docs-html.zip
{ "status": "ok", "id": "9222-1679515278-1" }
$ curl -s -I https://docs.python.org/ftp/python/doc/3.10.4/python-3.10.4-docs-html.zip
HTTP/2 301 
server: nginx
content-type: text/html
location: https://www.python.org/ftp/python/doc/3.10.4/python-3.10.4-docs-html.zip

note that it'll take some time for the current cached redirects to expire.

@hugovk
Copy link
Member

hugovk commented Mar 23, 2023

Testing an arbitrary version, all the download links now work: https://docs.python.org/release/3.9.3/download.html

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir
Projects
None yet
Development

No branches or pull requests

8 participants