Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracemalloc should skip incomplete frames when creating traceback. #96612

Closed
markshannon opened this issue Sep 6, 2022 · 1 comment
Closed

Tracemalloc should skip incomplete frames when creating traceback. #96612

markshannon opened this issue Sep 6, 2022 · 1 comment
Assignees
@markshannon
Labels
3.11 only security fixes 3.12 bugs and security fixes type-bug An unexpected behavior, bug, or error

Comments

@markshannon
Copy link
Member

markshannon commented Sep 6, 2022 •
edited
Loading

In the process of implementing #96421, I discovered that tracemalloc doesn't filter out incomplete frames. This might be an issue when allocating in the RETURN_GENERATOR instruction.

This might only be a hypothetical problem, but it should be fixed anyway.
@markshannon markshannon added type-bug An unexpected behavior, bug, or error 3.11 only security fixes 3.12 bugs and security fixes labels Sep 6, 2022
@markshannon markshannon self-assigned this Sep 6, 2022
@bedevere-bot bedevere-bot mentioned this issue Sep 6, 2022
Merged
markshannon added a commit that referenced this issue Sep 6, 2022
@markshannon
GH-96612: Skip incomplete frames in tracemalloc traces. (GH-96613)
95e271b
markshannon added a commit that referenced this issue Sep 6, 2022
@markshannon
[3.11] GH-96612: Skip incomplete frames in tracemalloc traces. (GH-96613
6f74ada 
)

(cherry picked from commit 95e271b)

Co-authored-by: Mark Shannon <mark@hotpy.org>
@bedevere-bot bedevere-bot mentioned this issue Sep 6, 2022
Merged
pablogsal pushed a commit that referenced this issue Sep 6, 2022
@markshannon
[3.11] GH-96612: Skip incomplete frames in tracemalloc traces. (GH-96613
26dc4df 
) (#96617)

(cherry picked from commit 95e271b)

Co-authored-by: Mark Shannon <mark@hotpy.org>
@kumaraditya303
Copy link
Contributor

Fixed by #96613

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markshannon markshannon

Labels
3.11 only security fixes 3.12 bugs and security fixes type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@markshannon @kumaraditya303