Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-35035: Rename email.utils documentation to email.utils.rst #10023

Merged
merged 1 commit into from Nov 21, 2018
Merged

bpo-35035: Rename email.utils documentation to email.utils.rst #10023

merged 1 commit into from Nov 21, 2018

Conversation

zmwangx
Copy link
Contributor

@zmwangx zmwangx commented Oct 21, 2018 •
edited

@zmwangx zmwangx requested a review from a team as a code owner October 21, 2018 06:25
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Oct 21, 2018
@vstinner
Copy link
Member

@bitdancer: Oh, it looks like an obvious typo in the documentation filename. Is it legit or not? :-)

vstinner
vstinner approved these changes Oct 24, 2018
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zmwangx
Copy link
Contributor Author

zmwangx commented Oct 24, 2018

Oops, there's a typo in the commit title, too...

@zmwangx zmwangx changed the title bpo-35035: Rename email.util documentation to email.utils.rst bpo-35035: Rename email.utils documentation to email.utils.rst Oct 24, 2018
@vstinner
Copy link
Member

Oops, there's a typo in the commit title, too...

Ah ah. It can be fixed when the change is merged.

@JulienPalard JulienPalard merged commit 361e868 into python:master Nov 21, 2018
@miss-islington
Copy link
Contributor

Thanks @zmwangx for the PR, and @JulienPalard for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6, 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 21, 2018
@zmwangx @miss-islington
bpo-35035: Rename email.utils documentation to email.utils.rst (pytho…
685dac0 
…nGH-10023)

I'll watch for 404 on the old URL and will setup an HTTP redirection if needed.
(cherry picked from commit 361e868)

Co-authored-by: Zhiming Wang <github@zmwang.pw>
@bedevere-bot
Copy link

GH-10635 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 21, 2018
@zmwangx @miss-islington
bpo-35035: Rename email.utils documentation to email.utils.rst (pytho…
7cff321 
…nGH-10023)

I'll watch for 404 on the old URL and will setup an HTTP redirection if needed.
(cherry picked from commit 361e868)

Co-authored-by: Zhiming Wang <github@zmwang.pw>
@bedevere-bot
Copy link

GH-10636 is a backport of this pull request to the 3.6 branch.

@miss-islington
Copy link
Contributor

Sorry, @zmwangx and @JulienPalard, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 361e8683e7340c600b22f4a514b81448ccec66dc 2.7

JulienPalard pushed a commit that referenced this pull request Nov 21, 2018
@miss-islington @zmwangx @JulienPalard
bpo-35035: Rename email.utils documentation to email.utils.rst (GH-10023
27c16e3 
)

I'll watch for 404 on the old URL and will setup an HTTP redirection if needed.
(cherry picked from commit 361e868)

Co-authored-by: Zhiming Wang <github@zmwang.pw>
JulienPalard pushed a commit that referenced this pull request Nov 21, 2018
@miss-islington @zmwangx @JulienPalard
[3.7] bpo-35035: Rename email.utils documentation to email.utils.rst (G…
3b7258a 
…H-10023)

I'll watch for 404 on the old URL and will setup an HTTP redirection if needed.
(cherry picked from commit 361e868)

Co-authored-by: Zhiming Wang <github@zmwang.pw>
@zmwangx zmwangx deleted the email.utils-doc-rename branch November 21, 2018 18:13
JulienPalard pushed a commit to JulienPalard/cpython that referenced this pull request Nov 22, 2018
@zmwangx @JulienPalard
[2.7] bpo-35035: Rename email.utils documentation to email.utils.rst (p…
6fd441a 
…ythonGH-10023)

I'll watch for 404 on the old URL and will setup an HTTP redirection if needed..
(cherry picked from commit 361e868)

Co-authored-by: Zhiming Wang <github@zmwang.pw>
@bedevere-bot
Copy link

GH-10667 is a backport of this pull request to the 2.7 branch.

miss-islington pushed a commit that referenced this pull request Nov 22, 2018
@JulienPalard @miss-islington
[2.7] bpo-35035: Rename email.utils documentation to email.utils.rst (G…
daa34b8 
…H-10023) (GH-10667)

https://bugs.python.org/issue35035
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

Assignees

@JulienPalard JulienPalard

Labels
docs Documentation in the Doc dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@zmwangx @vstinner @miss-islington @bedevere-bot @JulienPalard @the-knights-who-say-ni