Skip to content

gh-100220: Fix error handling in make rules #100328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 7, 2023
Merged

gh-100220: Fix error handling in make rules #100328

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6c05684
pythongh-100220: Fix error handling in make rules
mgorny Dec 18, 2022
86c946f
Set shell flag `-e` globally
mgorny Mar 3, 2023
ef886de
Merge branch 'main' into make-fail-100220
arhadthedev Apr 5, 2023
4006cd4
Update Misc/NEWS.d/next/Build/2022-12-18-07-24-44.gh-issue-100220.BgS…
zware Apr 7, 2023
46cd0c0
Merge branch 'main' into make-fail-100220
zware Apr 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile.pre.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ DSYMUTIL_PATH= @DSYMUTIL_PATH@
GNULD= @GNULD@

# Shell used by make (some versions default to the login shell, which is bad)
SHELL= /bin/sh
SHELL= /bin/sh -e

# Use this to make a link between python$(VERSION) and python in $(BINDIR)
LN= @LN@
Expand Down
4 changes: 4 additions & 0 deletions Misc/NEWS.d/next/Build/2022-12-18-07-24-44.gh-issue-100220.BgSV7C.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Changed the default value of the ``SHELL`` Makefile variable from ``/bin/sh``
to ``/bin/sh -e`` to ensure that complex recipes correctly fail after an error.
Previously, ``make install`` could fail to install some files and yet return
a successful result.