gh-82052: Don't send partial UTF-8 sequences to the Windows API #101103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, I don't think this can be tested without mocking native APIs. And while I think we can do that now (for console stuff), we don't have the infrastructure set up for it, and no need to add it for this. I approve this, so merge whenever you're happy. |
zooba
added
needs backport to 3.10
|
Thanks @pfmoore for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
|
GH-101107 is a backport of this pull request to the 3.11 branch. |
|
GH-101108 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 17, 2023
…pythonGH-101103) Don't send partial UTF-8 sequences to the Windows API (cherry picked from commit f34176b) Co-authored-by: Paul Moore <p.f.moore@gmail.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 17, 2023
…pythonGH-101103) Don't send partial UTF-8 sequences to the Windows API (cherry picked from commit f34176b) Co-authored-by: Paul Moore <p.f.moore@gmail.com>
miss-islington
added a commit
that referenced
this pull request
Jan 17, 2023
miss-islington
added a commit
that referenced
this pull request
Jan 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #82052
This doesn't include a test, as I'm not sure how I would write a test for it. The only reproducer I am aware of involves sending output to the console screen and visually inspecting it. I've validated that this PR fixes the issue by doing that test, but it's not something I know how to automate.