Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-33944: note about the intended use of code in .pth files #10131

Merged
merged 3 commits into from Sep 11, 2019

Conversation

@native-api
Copy link
Contributor

commented Oct 26, 2018

@terryjreedy
Copy link
Member

left a comment

I highly approve of augmenting the doc as an alternative to deprecating this useful feature. With one optional suggestion, the text looks good according to the discussion. Another core dev should approve and commit.

Doc/library/site.rst Outdated Show resolved Hide resolved
@bedevere-bot

This comment has been minimized.

Copy link

commented Oct 26, 2018

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@native-api

This comment has been minimized.

Copy link
Contributor Author

commented Oct 26, 2018

I have made the requested changes; please review again

@bedevere-bot

This comment has been minimized.

Copy link

commented Oct 26, 2018

Thanks for making the requested changes!

@terryjreedy: please review the changes made to this pull request.

@miss-islington

This comment has been minimized.

Copy link

commented Sep 11, 2019

Sorry, I can't merge this PR. Reason: Base branch was modified. Review and try the merge again..

@miss-islington miss-islington merged commit f9b5840 into python:master Sep 11, 2019

5 checks passed

Azure Pipelines PR #20181026.57 succeeded
Details
bedevere/issue-number Issue number 33944 found
Details
bedevere/news News entry found in Misc/NEWS.d
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@miss-islington

This comment has been minimized.

Copy link

commented Sep 11, 2019

Thanks @native-api for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒🤖

miss-islington added a commit to miss-islington/cpython that referenced this pull request Sep 11, 2019
@bedevere-bot

This comment has been minimized.

Copy link

commented Sep 11, 2019

GH-15942 is a backport of this pull request to the 3.8 branch.

matrixise added a commit that referenced this pull request Sep 11, 2019
bpo-33944: note about the intended use of code in .pth files (GH-10131)…
… (GH-15942)

https://bugs.python.org/issue33944
(cherry picked from commit f9b5840)

Co-authored-by: native-api <ivan_pozdeev@mail.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.