Skip to content

Conversation

yuting-liu
Copy link

@yuting-liu yuting-liu commented Mar 4, 2023

gh-102430: Added the _heappush_max for the heap push operation in max heap.

@bedevere-bot
Copy link

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@ghost
Copy link

ghost commented Mar 4, 2023

The following commit authors need to sign the Contributor License Agreement:

Click the button to sign:
CLA not signed

@yuting-liu yuting-liu changed the title Add max heap version of heappush gh-102430 Add max heap version of heappush Mar 5, 2023
@yuting-liu yuting-liu marked this pull request as ready for review March 5, 2023 01:49
@yuting-liu yuting-liu requested a review from rhettinger as a code owner March 5, 2023 01:49
@yuting-liu yuting-liu force-pushed the yuting-add-max-heap-push branch from 03c0be9 to c7c7ce7 Compare March 5, 2023 01:51
@bedevere-bot
Copy link

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@bedevere-bot
Copy link

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@rhettinger
Copy link
Contributor

Thank you for this; however, it conflicts will another PR that I've been working on to make all of the max heap functions public and to add the missing ones. The good news is that the next Python release will have exactly what you want.

@rhettinger rhettinger closed this Mar 5, 2023
@yuting-liu yuting-liu deleted the yuting-add-max-heap-push branch March 7, 2023 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants