Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-89415: Mention new IP_* constants in socket module in the docs #105266

Merged
merged 1 commit into from
Jun 3, 2023
Merged

gh-89415: Mention new IP_* constants in socket module in the docs #105266

merged 1 commit into from
Jun 3, 2023

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Jun 3, 2023 •
edited by github-actions bot

I was working on typeshed PR when I've noticed that only one IP_* constant was mentioned in the docs. Others from #103684 were missing.

So, here they are! 👍

📚 Documentation preview 📚: https://cpython-previews--105266.org.readthedocs.build/

@sobolevn sobolevn added skip news needs backport to 3.12 bug and security fixes labels Jun 3, 2023
@sobolevn sobolevn requested a review from gpshead June 3, 2023 07:21
@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir labels Jun 3, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jun 3, 2023
Closed
@gpshead gpshead merged commit eaff9c3 into python:main Jun 3, 2023
24 checks passed
@miss-islington
Copy link
Contributor

Thanks @sobolevn for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 3, 2023
@sobolevn @miss-islington
pythongh-89415: Mention new IP_* constants in socket module in th…
dfb4375 
…e docs (pythonGH-105266)

(cherry picked from commit eaff9c3)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-bot
Copy link

GH-105270 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 bug and security fixes label Jun 3, 2023
gpshead pushed a commit that referenced this pull request Jun 3, 2023
@miss-islington @sobolevn
[3.12] gh-89415: Mention new IP_* constants in socket module in t…
f629d5f 
…he docs (GH-105266) (#105270)

gh-89415: Mention new `IP_*` constants in `socket` module in the docs (GH-105266)
(cherry picked from commit eaff9c3)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@erlend-aasland erlend-aasland mentioned this pull request Jun 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpshead gpshead Awaiting requested review from gpshead

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sobolevn @miss-islington @bedevere-bot @gpshead