bpo-29521 update Misc/ACKS #106

merged 1 commit into from Feb 15, 2017


None yet

4 participants


I missed adding @JDLH into Misc/ACKS in GH-41 ๐Ÿ™
Sorry about that... Hope it's not too late.๐Ÿ˜ธ
Will cherry-pick into 3.5 and 3.6 ๐Ÿ’

@Mariatta Mariatta bpo-29521 update Misc/ACKS
JDLH commented Feb 15, 2017

@Mariatta is very kind, but @JDLH did very little for Python so far. I think mentioning me in this pass is not terribly important. I am working on some other changes, and those will be more worth a mention. It will happen sooner or later.

haypo approved these changes Feb 15, 2017 View changes
@haypo haypo merged commit 85064db into python:master Feb 15, 2017

2 checks passed

codecov/patch Coverage not affected.
continuous-integration/travis-ci/pr The Travis CI build passed
haypo commented Feb 15, 2017

Oh strange, I was able to merge the two cherry-picked PR for 3.5 and 3.6 before this one. On a backport, I was able to click on a commit number 6420088 which seems to be part of the master branch, but in fact it came from this pending PR.

And when I found the PR, I saw a discussion with @JDLH. Sorry Jim, I had to merge this PR since I merged the two "cherry-picked" commits before :-)

@Mariatta Mariatta deleted the Mariatta:bpo-29521-acks-master branch Feb 15, 2017

Thanks @haypo ๐ŸŽ‰

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment